Typescript: Fix types of client-api & storystore #7337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the function to merge all decorators & storyFn has been changed to no longer mutate the storyFn called from within decorators must be called with a StoryContext add a story for vue to test the behaviour
ndelangen
added
api: stories
maintenance
ndelangen
requested review from
alexandrebodin,
danielduan,
igor-dv,
kazupon,
thomasbertet and
usulpro
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fix-decoratestory.storybook.now.sh |
shilman
approved these changes
Jul 8, 2019
There was a problem hiding this comment.
LGTM let's see what @tmeasday @igor-dv @Hypnosphi say about this hopefully minor breaking change
|
I'd love to merge this ASAP, so I can continue with the app/react & app/angular mergers |
Jessica-Koch
reviewed
Jul 9, 2019
Jessica-Koch
reviewed
Jul 9, 2019
examples/vue-kitchen-sink/src/stories/custom-decorators.stories.js
Outdated
Show resolved
Hide resolved
Jessica-Koch
approved these changes
Jul 9, 2019
|
ping @Hypnosphi @igor-dv we'd really like your opinion about this change. |
Hypnosphi
reviewed
Jul 14, 2019
Hypnosphi
approved these changes
Jul 14, 2019
shilman
reviewed
Jul 15, 2019
lib/api/src/version.ts
Outdated
| @@ -1 +1 @@ | |||
| export const version = '5.2.0-alpha.39'; | |||
There was a problem hiding this comment.
@ndelangen Please don't modify this file. It only causes merge conflicts down the line.
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did