REMOVE tslint, and use eslint for everything #6621

ndelangen · 2019-04-25T13:15:48Z

Issue: TSlint will get replaced with ESlint at some point (see this article for explanations on why), having 2 linters is annoying:

more processes to run
more caching to configure
more editor config

What I did

CHANGE the Eslint config so it can parse .ts,.tsx,.mjs files
REMOVE tslint
now that eslint rules are having an effect on typescript code, I did a ton of fixes
had to do some additional fixes to avoid using ts-loader, related: Pass all files other then node_modules though babel loader by default #6566

vercel · 2019-04-25T13:15:54Z

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-tech-remove-tslint.storybook.now.sh

codecov · 2019-04-25T13:17:12Z

Codecov Report

Merging #6621 into next will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next    #6621      +/-   ##
==========================================
+ Coverage   40.48%   40.57%   +0.08%     
==========================================
  Files         637      637              
  Lines        8743     8714      -29     
  Branches      636      625      -11     
==========================================
- Hits         3540     3536       -4     
+ Misses       5106     5089      -17     
+ Partials       97       89       -8

Impacted Files	Coverage Δ
lib/api/src/modules/shortcuts.ts	`19% <0%> (-0.2%)`	⬇️
addons/info/src/components/types/PrettyPropType.js	`41.66% <0%> (ø)`	⬆️
addons/info/src/components/types/OneOfType.js	`28.57% <0%> (ø)`	⬆️
addons/a11y/src/components/Report/Elements.tsx	`41.66% <0%> (ø)`	⬆️
addons/a11y/src/components/Report/Item.tsx	`66.66% <0%> (ø)`	⬆️
addons/info/src/components/types/ObjectOf.js	`66.66% <0%> (ø)`	⬆️
lib/theming/src/base.ts	`100% <0%> (ø)`	⬆️
addons/info/src/components/types/ArrayOf.js	`66.66% <0%> (ø)`	⬆️
lib/theming/src/create.ts	`77.27% <0%> (ø)`	⬆️
addons/info/src/components/types/Shape.js	`28.57% <0%> (ø)`	⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62bca85...3310029. Read the comment docs.

codecov · 2019-04-25T13:17:12Z

Codecov Report

Merging #6621 into next will decrease coverage by 0.02%.
The diff coverage is 34.44%.

@@            Coverage Diff             @@
##             next    #6621      +/-   ##
==========================================
- Coverage   40.48%   40.46%   -0.03%     
==========================================
  Files         637      637              
  Lines        8743     8754      +11     
  Branches      636      635       -1     
==========================================
+ Hits         3540     3542       +2     
- Misses       5106     5115       +9     
  Partials       97       97

Impacted Files	Coverage Δ
app/preact/src/client/preview/render.js	`0% <ø> (ø)`	⬆️
lib/ui/src/keyboard/keyCodes.ts	`0% <ø> (ø)`	⬆️
addons/jest/src/hoc/provideJestResult.tsx	`0% <ø> (ø)`	⬆️
addons/a11y/src/components/A11YPanel.tsx	`89.47% <ø> (ø)`	⬆️
addons/contexts/src/manager/ContextsManager.tsx	`0% <ø> (ø)`	⬆️
lib/api/src/index.tsx	`0% <ø> (ø)`	⬆️
lib/components/src/ActionBar/ActionBar.tsx	`100% <ø> (ø)`	⬆️
addons/contexts/src/manager/libs/useChannel.ts	`0% <ø> (ø)`	⬆️
addons/a11y/src/components/Report/Rules.tsx	`29.03% <ø> (ø)`	⬆️
...ns/contexts/src/manager/components/ToolBarMenu.tsx	`0% <ø> (ø)`	⬆️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba0541...1546f88. Read the comment docs.

# Conflicts: # yarn.lock

shilman · 2019-04-25T16:33:35Z

addons/a11y/src/components/Report/HighlightToggle.tsx

    }
  }

+  onToggle = (): void => {


What are these changes?

Linting fixes, typescript files were missing a ton of useful eslint rules!

Now all eslint rules apply to typescript code as well 🎉

# Conflicts: # yarn.lock

…s loading

examples/official-storybook/webpack.config.js

shilman

Love it! One weird configuration change above, otherwise looks fantastic 🎉

addons/a11y/src/components/ColorBlindness.tsx

gaetanmaisse · 2019-04-26T06:29:25Z

addons/contexts/src/shared/types.d.ts

    name: string;
    props: GenericProp;
    default?: boolean;
-  }>;
+  }[];


Not sure about this one, I think Array<> is easier to read. What other devs are thinking about it?

I agree personally on that I find Array<X> to be easier to read then X[], but this is a recommended rule from the typescript folk

examples/cra-ts-kitchen-sink/src/react-app-env.d.ts

examples/official-storybook/webpack.config.js

what a strange world we live in where a triple slash means something other then a code comment

shilman

Beautiful! 👌

Hypnosphi · 2019-09-04T16:50:19Z

.eslintrc.js

@@ -94,13 +113,21 @@ module.exports = {
      error,
      { allow: ['__STORYBOOK_CLIENT_API__', '__STORYBOOK_ADDONS_CHANNEL__'] },
    ],
+    '@typescript-eslint/no-var-requires': ignore,
+    '@typescript-eslint/camelcase': ignore,
+    '@typescript-eslint/no-unused-vars': ignore,


Hypnosphi · 2019-10-03T11:39:05Z

examples/official-storybook/webpack.config.js

+              presets: [
+                ['@babel/preset-env', { shippedProposals: true, useBuiltIns: 'usage', corejs: 2 }],
+                '@babel/preset-typescript',
+                ['babel-preset-minify', { builtIns: false, mangle: false }],


@ndelangen shouldn't we apply this one only in prod mode?

ndelangen added the maintenance User-facing maintenance tasks label Apr 25, 2019

ndelangen self-assigned this Apr 25, 2019

ndelangen added 3 commits April 25, 2019 15:34

REMOVE tslint, and use eslint for everything

0296ef7

just a few little linting issues fixed

f939e14

FIX yarn.lock

d0d5ab3

ndelangen force-pushed the tech/remove-tslint branch from 3310029 to d0d5ab3 Compare April 25, 2019 16:13

ndelangen requested review from alexandrebodin, alterx, CodeByAlex, dangreenisrael, danielduan, Gongreg, igor-dv, jbovenschen, kazupon, leonrodenburg, thani-sh, renaudtertrais, rmevans9, shilman, stijnkoopal, theinterned, thomasbertet, tmeasday and usulpro as code owners April 25, 2019 16:13

vercel bot had a problem deploying to staging April 25, 2019 16:13 Failure

Merge branch 'next' into tech/remove-tslint

022429a

# Conflicts: # yarn.lock

vercel bot temporarily deployed to staging April 25, 2019 16:26 Inactive

shilman reviewed Apr 25, 2019

View reviewed changes

REMOVE info about yarn linking && ADD info about linting

b708eaf

vercel bot had a problem deploying to staging April 25, 2019 16:34 Failure

ndelangen added 2 commits April 25, 2019 19:34

Merge branch 'next' into tech/remove-tslint

bfb5546

FIX yarn.lock

61d9551

vercel bot had a problem deploying to staging April 25, 2019 17:41 Failure

ndelangen added 2 commits April 25, 2019 21:26

Merge branch 'next' into tech/remove-tslint

44b5ace

# Conflicts: # yarn.lock

FIX angular test & storybook build

4280795

vercel bot had a problem deploying to staging April 25, 2019 21:02 Failure

ndelangen added 2 commits April 25, 2019 23:59

FIX lint issue

a739c75

CHANGE the loader for most code in the official example, unify js & t…

62f13a4

…s loading

vercel bot deployed to staging April 26, 2019 00:06 View deployment

FIX cache dir

4e7da65

vercel bot deployed to staging April 26, 2019 00:26 View deployment

shilman reviewed Apr 26, 2019

View reviewed changes

examples/official-storybook/webpack.config.js Outdated Show resolved Hide resolved

shilman requested changes Apr 26, 2019

View reviewed changes

gaetanmaisse reviewed Apr 26, 2019

View reviewed changes

FIX incorrect triple slash something

1546f88

what a strange world we live in where a triple slash means something other then a code comment

vercel bot deployed to staging April 26, 2019 07:53 View deployment

gaetanmaisse approved these changes Apr 26, 2019

View reviewed changes

ndelangen removed request for rmevans9, usulpro and CodeByAlex April 26, 2019 08:52

shilman approved these changes Apr 26, 2019

View reviewed changes

shilman merged commit 8aae29d into next Apr 26, 2019

shilman deleted the tech/remove-tslint branch April 26, 2019 09:01

Hypnosphi reviewed Sep 4, 2019

View reviewed changes

Hypnosphi reviewed Oct 3, 2019

View reviewed changes

Hypnosphi mentioned this pull request Oct 3, 2019

Official examples: apply babel-preset-minify only in production mode #8283

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

REMOVE tslint, and use eslint for everything #6621

REMOVE tslint, and use eslint for everything #6621

ndelangen commented Apr 25, 2019 •

edited

Loading

vercel bot commented Apr 25, 2019

codecov bot commented Apr 25, 2019

codecov bot commented Apr 25, 2019 •

edited

Loading

shilman Apr 25, 2019

ndelangen Apr 25, 2019

shilman left a comment

gaetanmaisse Apr 26, 2019

ndelangen Apr 26, 2019

shilman left a comment

Hypnosphi Sep 4, 2019

Hypnosphi Oct 3, 2019

ndelangen Oct 3, 2019

REMOVE tslint, and use eslint for everything #6621

REMOVE tslint, and use eslint for everything #6621

Conversation

ndelangen commented Apr 25, 2019 • edited Loading

What I did

vercel bot commented Apr 25, 2019

codecov bot commented Apr 25, 2019

Codecov Report

codecov bot commented Apr 25, 2019 • edited Loading

Codecov Report

shilman Apr 25, 2019

Choose a reason for hiding this comment

ndelangen Apr 25, 2019

Choose a reason for hiding this comment

shilman left a comment

Choose a reason for hiding this comment

gaetanmaisse Apr 26, 2019

Choose a reason for hiding this comment

ndelangen Apr 26, 2019

Choose a reason for hiding this comment

shilman left a comment

Choose a reason for hiding this comment

Hypnosphi Sep 4, 2019

Choose a reason for hiding this comment

Hypnosphi Oct 3, 2019

Choose a reason for hiding this comment

ndelangen Oct 3, 2019

Choose a reason for hiding this comment

ndelangen commented Apr 25, 2019 •

edited

Loading

codecov bot commented Apr 25, 2019 •

edited

Loading