Emit event on updating background #6561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-pajter-feature-addon-bac.storybook.now.sh |
pajter
commented
Apr 18, 2019
| change = (args: State) => this.setState(args); | ||
| change = ({ selected, name }: { selected: string; name: string }) => { | ||
| this.props.api.emit(EVENTS.UPDATE, { selected, name }); | ||
| this.setState({ selected, expanded: false }); |
There was a problem hiding this comment.
The menu always closes when selecting a color, so I moved expanded: false into here.
Codecov Report
@@ Coverage Diff @@
## next #6561 +/- ##
==========================================
- Coverage 40.69% 40.68% -0.01%
==========================================
Files 616 616
Lines 8534 8536 +2
Branches 600 600
==========================================
Hits 3473 3473
- Misses 4972 4974 +2
Partials 89 89
Continue to review full report at Codecov.
|
ndelangen
approved these changes
Apr 18, 2019
This was referenced Mar 16, 2020
This was referenced Apr 7, 2022
This was referenced May 13, 2022
This was referenced May 13, 2022
This was referenced May 14, 2022
This was referenced May 14, 2022
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: n/a
What I did
I made the backgrounds addon emit an event when a user changes the background. This allows developers to listen for this event and implement any custom logic they need in their own Storybook (plugin), eg. setting a class name for theming on the preview body element based on the background color (light/dark).
I'm not sure if there's a specific convention I should follow for event names. I looked at and copied what I found in other addons.
How to test
storybook/background/updateevent message in the console