Fix deprecationThemeOptions that always override final brand object with undefined #6522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndefined and null
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-lonyele-fix-render-brand-object.storybook.now.sh |
ndelangen
approved these changes
Apr 18, 2019
|
@lonyele can you verify the fix is still needed and if so resolve the merge conflict? |
|
@ndelangen since #6543 is merged, I think this fix is not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6521
Previous PR that made this issue: #5402 (comment)
What I did
I changed to what previous code does.
How to test
Comments
Hi, deja-vue again... I found this while working on this PR.
As you can see from previous PR that made this issue, It has been not working from after PR is merged.
My understanding is when user inputs
name, url, it maps its values tobrandTitle, brandUrlwith deprecation warnings. However previous code always warns(console.log) deprecationThemeOptions warning whether user inputsnameorurland overridesbrandTitle, brandUrl, brandImagetoundefined, undefined, null. Thus whatever options passing from user doesn't do anything.