Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #6514

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Update index.md #6514

merged 1 commit into from
Apr 15, 2019

Conversation

taylonr
Copy link

@taylonr taylonr commented Apr 14, 2019

Defining a PARAM_KEY that will match what is used in the story.

Issue:
PARAM_KEY is not defined anywhere in the code. Additionally, it's not immediately clear that it should match the key used in the story (i.e. myAddon)

What I did

Added a line to define the PARAM_KEY and set it to myAddon

How to test

N/A -- Updated documentation

If you want to test the documentation, copy & paste the code as if you were creating your first add-on

Defining a `PARAM_KEY` that will match what is used in the story.
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman added api: addons documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 15, 2019
@shilman shilman added this to the 5.0.x milestone Apr 15, 2019
@shilman shilman merged commit 27c2052 into storybookjs:master Apr 15, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 28, 2019
shilman added a commit that referenced this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: addons documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants