Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc to explain nesting stories under titles #6406

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

Glazy
Copy link
Contributor

@Glazy Glazy commented Apr 3, 2019

Issue: N/A

What I did

Added a section to the 'Writing Stories' documentation explaining how to nest stories under titles in the Storybook sidebar.

@Glazy Glazy requested review from ndelangen and shilman as code owners April 3, 2019 20:32
@vercel
Copy link

vercel bot commented Apr 3, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-glazy-docs-nesting-under-titles.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Glazy! Maybe you can also mention that this is configurable using the hierarchyRootSeparator option and link to /configurations/options-parameter docs?

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 4, 2019
Add a section to the docs to show the user how to change the default
separator ("|") to something else
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #6406 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6406   +/-   ##
=======================================
  Coverage   38.31%   38.31%           
=======================================
  Files         649      649           
  Lines        9857     9857           
  Branches      388      388           
=======================================
  Hits         3777     3777           
  Misses       6020     6020           
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddecea8...97e67f5. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #6406 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6406   +/-   ##
=======================================
  Coverage   38.31%   38.31%           
=======================================
  Files         649      649           
  Lines        9857     9857           
  Branches      388      388           
=======================================
  Hits         3777     3777           
  Misses       6020     6020           
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddecea8...97e67f5. Read the comment docs.

@Glazy
Copy link
Contributor Author

Glazy commented Apr 4, 2019

Awesome idea @shilman 💪My latest commit adds a section that explains this 👍

@shilman shilman added this to the 5.0.x milestone Apr 4, 2019
@shilman shilman merged commit 3dd6539 into storybookjs:next Apr 4, 2019
@shilman
Copy link
Member

shilman commented Apr 4, 2019

Boom!!! 💥

@Glazy Glazy deleted the docs/nesting-under-titles branch April 4, 2019 15:17
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 5, 2019
shilman added a commit that referenced this pull request Apr 5, 2019
Add doc to explain nesting stories under titles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants