Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing props in stories #6353

Merged
merged 3 commits into from
Apr 26, 2019

Conversation

aamct2
Copy link
Contributor

@aamct2 aamct2 commented Mar 31, 2019

What I did

  • A couple of the stories were throwing errors in the console when running the Official Storybook example as they were missing some required props. I've added them in.

How to test

  • Run the Official Storybook example and open the console. You should see no more missing prop errors.

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #6353 into next will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6353   +/-   ##
=======================================
  Coverage   40.81%   40.81%           
=======================================
  Files         616      616           
  Lines        8519     8519           
  Branches      535      535           
=======================================
  Hits         3477     3477           
  Misses       4950     4950           
  Partials       92       92
Impacted Files Coverage Δ
lib/ui/src/components/preview/iframe.stories.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663f497...4bc415d. Read the comment docs.

@Armanio Armanio added patch:yes Bugfix & documentation PR that need to be picked to main branch bug labels Mar 31, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Armanio
Copy link
Member

Armanio commented Apr 14, 2019

Hi @aamct2! Could you resolve conflicts? I think we can merge it after resolving all problems. 👍

@vercel
Copy link

vercel bot commented Apr 15, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-aamct2-fix-stories-missing-props.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@shilman shilman added the ui label Apr 15, 2019
@shilman shilman added this to the 5.0.x milestone Apr 15, 2019
@ndelangen ndelangen merged commit 6b4ff39 into storybookjs:next Apr 26, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 28, 2019
shilman pushed a commit that referenced this pull request Apr 28, 2019
Add missing props in stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants