Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #6333

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Update index.md #6333

merged 1 commit into from
Mar 28, 2019

Conversation

sleblang
Copy link

Under the heading - Step 5: Write your stories

  • Sample Angular doc code adds two instances of emoji button component rather than an instance of a text button component (see line 133)

Issue:

  • Sample code for text button component in Angular doc is incorrect - showing emoji code;

What I did

  • Added in text button sample code from demo angular project;

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

Under the heading - Step 5: Write your stories
- Sample code adds two instances of emoji button component rather than an instance of a text button component (see line 133)
@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #6333 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6333   +/-   ##
=======================================
  Coverage   35.06%   35.06%           
=======================================
  Files         636      636           
  Lines        9366     9366           
  Branches     1320     1320           
=======================================
  Hits         3284     3284           
  Misses       5436     5436           
  Partials      646      646

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6377ab...d2a2d08. Read the comment docs.

@gaetanmaisse gaetanmaisse added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 28, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shilman shilman merged commit 90013d2 into storybookjs:master Mar 28, 2019
@shilman shilman added this to the 5.0.x milestone Mar 28, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 29, 2019
shilman added a commit that referenced this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants