Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade babel-plugin-react-docgen #6317

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Upgrade babel-plugin-react-docgen #6317

merged 1 commit into from
Mar 28, 2019

Conversation

danielduan
Copy link
Member

Issue: storybookjs/babel-plugin-react-docgen#67

What I did

  • Add support for forwardRef functions
  • Upgrade react-docgen to pull in new features
  • Upgrade lodash to fix security vulerability

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #6317 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6317   +/-   ##
=======================================
  Coverage   35.06%   35.06%           
=======================================
  Files         636      636           
  Lines        9366     9366           
  Branches     1343     1320   -23     
=======================================
  Hits         3284     3284           
  Misses       5436     5436           
  Partials      646      646

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548d919...0e231ad. Read the comment docs.

@danielduan
Copy link
Member Author

@ndelangen am I still good to merge with these failing builds?

@shilman shilman added this to the v5.1.0 milestone Mar 28, 2019
@shilman shilman merged commit 658b5af into master Mar 28, 2019
@shilman shilman deleted the dd/docgen-upgrade branch March 28, 2019 01:49
@shilman
Copy link
Member

shilman commented Mar 28, 2019

@danielduan I merged this and then reverted it. PRs should be directed at the next branch. Will create a new PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants