Added missing background color for left panel #6315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a problem when working on an app with darker background
EskelCz
requested review from
danielduan,
Gongreg,
rmevans9 and
tmeasday
as code owners
Keraito
approved these changes
Mar 27, 2019
|
Great to have this fixed @EskelCz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a problem when working on an app with darker background. It might only be a problem for react-native-navigation apps, which uses different rootView structure.
Issue: Discord conversation
What I did
Added white background to the left panel
How to test
Open DeviceUI on React Native, work a view with black background, other panels should be white.
Maybe with screenshots, not sure. Just not necessary in my opinion.
No.
No.