-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Fix for addon-cssresources
till scrollbars are properly addressed
#6263
Merged
shilman
merged 3 commits into
storybookjs:next
from
pgoforth:defect/addon-cssresources_scrollbars
Mar 29, 2019
Merged
[bug] Fix for addon-cssresources
till scrollbars are properly addressed
#6263
shilman
merged 3 commits into
storybookjs:next
from
pgoforth:defect/addon-cssresources_scrollbars
Mar 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
patch:yes
Bugfix & documentation PR that need to be picked to main branch
addon: cssresources
labels
Mar 26, 2019
ndelangen
approved these changes
Mar 27, 2019
A test needs to be updated:
@pgoforth Are you able to do this? |
I can do that @ndelangen Edit: All done @ndelangen |
pgoforth
requested review from
aaronmcadam,
alexandrebodin,
alterx,
dangreenisrael,
danielduan,
Gongreg,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
naipath,
renaudtertrais,
rmevans9,
saponifi3d,
shilman,
stijnkoopal,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
March 28, 2019 18:32
pgoforth
force-pushed
the
defect/addon-cssresources_scrollbars
branch
from
March 28, 2019 18:38
432fe77
to
470e0c0
Compare
pgoforth
force-pushed
the
defect/addon-cssresources_scrollbars
branch
from
March 28, 2019 19:08
470e0c0
to
d41a707
Compare
@pgoforth Still getting an error in CI:
|
@shilman @ndelangen |
shilman
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Apr 1, 2019
shilman
added a commit
that referenced
this pull request
Apr 1, 2019
…llbars [bug] Fix for `addon-cssresources` till scrollbars are properly addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
addon: cssresources
bug
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The absolute positioning caused by 79d2cd1#diff-77ef954da6ec85c57634e9e3c9cc9750 made the css resources tab contain overlapping source files:
The solution was to render them into a container instead of a
<Fragment>