Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix for addon-cssresources till scrollbars are properly addressed #6263

Merged

Conversation

pgoforth
Copy link
Contributor

The absolute positioning caused by 79d2cd1#diff-77ef954da6ec85c57634e9e3c9cc9750 made the css resources tab contain overlapping source files:

Screen Shot 2019-03-25 at 4 15 42 PM

The solution was to render them into a container instead of a <Fragment>

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch addon: cssresources labels Mar 26, 2019
@shilman shilman added this to the 5.0.x milestone Mar 26, 2019
@ndelangen
Copy link
Member

A test needs to be updated:

 FAIL  addons/cssresources/src/css-resource-panel.test.js
  ● CSSResourcePanel › constructor › should not render anything

    Expected <CssResourcePanel> to be empty render (false or null), but it was not
    Found Nodes HTML output: <div></div>

      57 | 
      58 |     it('should not render anything', () => {
    > 59 |       expect(node).toBeEmptyRender();
         |                    ^
      60 |     });
      61 |   });
      62 | 

      at Object.toBeEmptyRender (addons/cssresources/src/css-resource-panel.test.js:59:20)

@pgoforth Are you able to do this?

@pgoforth
Copy link
Contributor Author

pgoforth commented Mar 28, 2019

I can do that @ndelangen

Edit: All done @ndelangen

@pgoforth pgoforth force-pushed the defect/addon-cssresources_scrollbars branch from 432fe77 to 470e0c0 Compare March 28, 2019 18:38
@pgoforth pgoforth force-pushed the defect/addon-cssresources_scrollbars branch from 470e0c0 to d41a707 Compare March 28, 2019 19:08
@shilman
Copy link
Member

shilman commented Mar 28, 2019

@pgoforth Still getting an error in CI:

 FAIL  addons/cssresources/src/css-resource-panel.test.js
  ● CSSResourcePanel › constructor › should render an empty div

    expect(received).toEqual(expected)

    Expected value to equal:
      true
    Received:
      false

      57 | 
      58 |     it('should render an empty div', () => {
    > 59 |       expect(node.matchesElement('<div></div>')).toEqual(true);
         |                                                  ^
      60 |     });
      61 |   });
      62 | 

      at Object.toEqual (addons/cssresources/src/css-resource-panel.test.js:59:50)

@pgoforth
Copy link
Contributor Author

@shilman @ndelangen
Should be passing now

@shilman shilman merged commit 68faff4 into storybookjs:next Mar 29, 2019
@pgoforth pgoforth deleted the defect/addon-cssresources_scrollbars branch March 29, 2019 02:16
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 1, 2019
shilman added a commit that referenced this pull request Apr 1, 2019
…llbars

[bug] Fix for `addon-cssresources` till scrollbars are properly addressed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: cssresources bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants