Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(README): Update links to INITIAL_VIEWPORTS #6199

Merged
merged 1 commit into from
Mar 20, 2019
Merged

fix(README): Update links to INITIAL_VIEWPORTS #6199

merged 1 commit into from
Mar 20, 2019

Conversation

philipp-srf
Copy link
Contributor

Issue:

What I did

Fix the link to INITIAL_VIEWPORTS in readme.

@philipp-srf philipp-srf requested a review from saponifi3d as a code owner March 20, 2019 17:06
@philipp-srf philipp-srf changed the title Fix links to INITIAL_VIEWPORTS fix(README): Update links to INITIAL_VIEWPORTS Mar 20, 2019
@codecov
Copy link

codecov bot commented Mar 20, 2019 •
edited
Loading

Codecov Report

Merging #6199 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6199   +/-   ##
=======================================
  Coverage   38.13%   38.13%           
=======================================
  Files         645      645           
  Lines        9643     9643           
  Branches      355      355           
=======================================
  Hits         3677     3677           
  Misses       5911     5911           
  Partials       55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bdb2ca...ec0695b. Read the comment docs.

wuweiweiwu
wuweiweiwu approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 20, 2019
@shilman shilman merged commit 7c0fa86 into storybookjs:next Mar 20, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 20, 2019
shilman added a commit that referenced this pull request Mar 20, 2019
@shilman
Merge pull request #6199 from philipp-srf/patch-4
0df0451 
fix(README): Update links to INITIAL_VIEWPORTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuweiweiwu wuweiweiwu wuweiweiwu approved these changes

@saponifi3d saponifi3d Awaiting requested review from saponifi3d

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipp-srf @wuweiweiwu @shilman