Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MIGRATION): add missing commas #6181

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Conversation

samouss
Copy link
Contributor

@samouss samouss commented Mar 19, 2019

Issue: The migration guide print non valid JavaScript for the full control mode.

What I did

I've added the two missing commas.

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #6181 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6181   +/-   ##
=======================================
  Coverage   37.93%   37.93%           
=======================================
  Files         645      645           
  Lines        9626     9626           
  Branches      352      352           
=======================================
  Hits         3652     3652           
  Misses       5927     5927           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b8243...86aed6f. Read the comment docs.

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 19, 2019
@shilman shilman added this to the 5.0.x milestone Mar 19, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 good catch!

@shilman shilman merged commit 5901c36 into storybookjs:next Mar 19, 2019
@samouss samouss deleted the patch-3 branch March 19, 2019 13:18
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 19, 2019
shilman added a commit that referenced this pull request Mar 19, 2019
fix(MIGRATION): add missing commas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants