Fix addon-knobs ObjectType knob react warning #5276

[leoyli]

Issue: #5276

What I did

• Fixed the getDerivedStateFromProps console warning due to no initial state provided to React.

How to test

• Is this testable with Jest or Chromatic screenshots?
  No

• Does this need a new example in the kitchen sink apps?
  No

• Does this need an update to the documentation?
  No

If your answer is yes to any of these, please make sure to include it in your PR.

[shilman]

@leoyli getting some linting errors:

/tmp/storybook/addons/knobs/src/components/types/Object.js
  12:7  error  Unused state field: 'values'  react/no-unused-state
  14:7  error  Unused state field: 'state'   react/no-unused-state

[codecov]

Codecov Report

Merging #6159 into next will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             next    #6159      +/-   ##
==========================================
- Coverage   38.04%   38.03%   -0.01%     
==========================================
  Files         643      643              
  Lines        9420     9422       +2     
  Branches     1373     1344      -29     
==========================================
  Hits         3584     3584              
- Misses       5268     5270       +2     
  Partials      568      568

Impacted Files	Coverage Δ
addons/knobs/src/components/types/Object.js	17.39% <0%> (-1.66%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c7ecbb...c574c1d. Read the comment docs.

[codecov]

Codecov Report

Merging #6159 into next will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             next    #6159      +/-   ##
==========================================
- Coverage   38.04%   38.03%   -0.01%     
==========================================
  Files         643      643              
  Lines        9420     9422       +2     
  Branches     1373     1373              
==========================================
  Hits         3584     3584              
- Misses       5268     5270       +2     
  Partials      568      568

Impacted Files	Coverage Δ
addons/knobs/src/components/types/Object.js	17.39% <0%> (-1.66%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c7ecbb...e34bbfc. Read the comment docs.

[leoyli]

@shilman, thanks for the heads up! For some reason I've made a typo here... I've made a correction. :)

[leoyli]

@shilman, I still see 1 checks is neutral/pending... Is this a blocker?! If so what should I do?!

[shilman]

Hi @leoyli This fixes the warning but looks like it causes a bug. When I run official-storybook on this branch I don't see the Styles options as I expect in the knobs UI. Here's what it should look like on next:

Mind digging in and see if you can figure out what's wrong?

[leoyli]

@shilman, Oh yes, I'm happy to make contributions to make this thing great. I will find a time during weekend to work on this. Thank you for your review and catching my bug!

[leoyli]

@shilman, I can see the problem you've mentioned. I have just committed a change to fix this, which is simpler and safer I believe. :) I have test in my local machine and ensure the knob running as expected and no printing ObjectType errors.

[shilman]

LGTM and working great. Thanks for fixing this @leoyli !

[leoyli]

Thank you for your review, I will try to find what else I can contribute!