📜[storysource] 📦 [sandpack] The clientApi must be reused when possible #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @shilman @tmeasday and @ndelangen. I think I spoke about it with you, but don't hesitate to discuss about the intent if you don't agree. |
Codecov Report
@@ Coverage Diff @@
## next #6154 +/- ##
==========================================
+ Coverage 38.04% 38.06% +0.01%
==========================================
Files 643 643
Lines 9420 9423 +3
Branches 1373 1345 -28
==========================================
+ Hits 3584 3587 +3
Misses 5268 5268
Partials 568 568
Continue to review full report at Codecov.
|
libetl
commented
Mar 18, 2019
| const storyStore = new StoryStore({ channel }); | ||
| const clientApi = new ClientApi({ storyStore, decorateStory }); | ||
| let storyStore; | ||
| let clientApi; |
There was a problem hiding this comment.
any way to make that const again ?
I know that Kotlin can do it. (free ad)
There was a problem hiding this comment.
I'd wrap it into a function, that way the result of the function can be a const
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
I am working on a topic : ability to live edit the story when on the screen, and ability to export the component as a project in codesandbox.
This will be done by upgrading the storysource addon, which could become an Integrated Development Environment
Sandpack will re-download storybook.
Then we must have an idempotent behavior, which means keeping control over code run several times.
In this case, we must prevent the clientApi from being created twice, instead we must reuse the currently existing one.
How to test
Is this testable with Jest or Chromatic screenshots?
I added one test to verify that it works.
Does this need a new example in the kitchen sink apps?
I don't think so.
Does this need an update to the documentation?
I don't think so.
If your answer is yes to any of these, please make sure to include it in your PR.