Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lerna badge in README #6064

Merged
merged 1 commit into from
Mar 13, 2019
Merged

add lerna badge in README #6064

merged 1 commit into from
Mar 13, 2019

Conversation

armujahid
Copy link
Member

What I did

added lerna badge in README

How to test

  • Is this testable with Jest or Chromatic screenshots? no need
  • Does this need a new example in the kitchen sink apps? no need
  • Does this need an update to the documentation? no need

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #6064 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6064   +/-   ##
=======================================
  Coverage   35.78%   35.78%           
=======================================
  Files         648      648           
  Lines        9520     9520           
  Branches     1352     1352           
=======================================
  Hits         3407     3407           
  Misses       5535     5535           
  Partials      578      578

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a664aa...c27ef10. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I appreciate how Lerna helps us maintain Storybook (it's truly awesome!), I don't think this badge is informative at the top of our README. I'd be open to creating some kind of acknowledgments section elsewhere in the documentation if we can find a good place for it.

@armujahid
Copy link
Member Author

@shilman
Copy link
Member

shilman commented Mar 13, 2019

@armujahid Maybe add a sentence to the beginning of the Development scripts section?

Storybook is organized as a monorepo using [Lerna](https://lernajs.io). Useful scripts include:

@shilman shilman added this to the 5.0.x milestone Mar 13, 2019
@armujahid
Copy link
Member Author

@shilman done

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@shilman shilman merged commit d6e4663 into storybookjs:next Mar 13, 2019
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 13, 2019
shilman added a commit that referenced this pull request Mar 13, 2019
@armujahid armujahid deleted the patch-3 branch March 15, 2019 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants