-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lerna badge in README #6064
Conversation
Codecov Report
@@ Coverage Diff @@
## next #6064 +/- ##
=======================================
Coverage 35.78% 35.78%
=======================================
Files 648 648
Lines 9520 9520
Branches 1352 1352
=======================================
Hits 3407 3407
Misses 5535 5535
Partials 578 578 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as I appreciate how Lerna helps us maintain Storybook (it's truly awesome!), I don't think this badge is informative at the top of our README. I'd be open to creating some kind of acknowledgments section elsewhere in the documentation if we can find a good place for it.
@armujahid Maybe add a sentence to the beginning of the Development scripts section?
|
@shilman done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙏
What I did
added lerna badge in README
How to test