Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-a11y: fix design icons #5991

Merged
merged 1 commit into from
Mar 10, 2019
Merged

Addon-a11y: fix design icons #5991

merged 1 commit into from
Mar 10, 2019

Conversation

Armanio
Copy link
Member

@Armanio Armanio commented Mar 9, 2019

Issue:
I notice what in a11y tab in 'rules' list icons not visible. It's not good. Fix it!

What I did

Mini clean css in 'rules'
Fix 'rules' text position

How to test

  1. Open official example
  2. Click 'Accessibility' tab
  3. Expand any rule
  4. You don't see icons

For more information please look at screenshots:
Before:
Снимок экрана 2019-03-10 в 1 28 46
After:
Снимок экрана 2019-03-10 в 1 29 28

I work in macbook 17' without fullscreen monitor, open devtool panel broken a11y rules list. I fix icon width and rules text align. Look at screenshots:
Before:
Снимок экрана 2019-03-10 в 1 37 45

After:
Снимок экрана 2019-03-10 в 1 38 23

  • Is this testable with Jest or Chromatic screenshots?
    no
  • Does this need a new example in the kitchen sink apps?
    no
  • Does this need an update to the documentation?
    no

@Armanio Armanio requested a review from jbovenschen as a code owner March 9, 2019 22:40
@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #5991 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5991   +/-   ##
=======================================
  Coverage   34.93%   34.93%           
=======================================
  Files         648      648           
  Lines        9515     9515           
  Branches     1351     1380   +29     
=======================================
  Hits         3324     3324           
  Misses       5574     5574           
  Partials      617      617
Impacted Files Coverage Δ
addons/a11y/src/components/Report/Item.tsx 0% <ø> (ø) ⬆️
addons/a11y/src/components/Report/Rules.tsx 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a4a6f...5456494. Read the comment docs.

@shilman shilman added addon: a11y bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 10, 2019
@shilman shilman added this to the 5.0.x milestone Mar 10, 2019
@gaetanmaisse gaetanmaisse merged commit 5c3dbbb into storybookjs:next Mar 10, 2019
@Armanio Armanio deleted the fix/a11y_rules_style branch March 10, 2019 09:55
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 17, 2019
shilman pushed a commit that referenced this pull request Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: a11y bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants