Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYNC prettier printWidth with eslint && FIX resulting linting warnings #5978

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

ndelangen
Copy link
Member

Issue: printWidth for eslint & typescript is configured differently

What I did

I set them to the same value & fixed all resulting warnings

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

Merging #5978 into next will increase coverage by <.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5978      +/-   ##
==========================================
+ Coverage   34.91%   34.92%   +<.01%     
==========================================
  Files         648      648              
  Lines        9496     9512      +16     
  Branches     1377     1350      -27     
==========================================
+ Hits         3316     3322       +6     
- Misses       5563     5573      +10     
  Partials      617      617
Impacted Files Coverage Δ
app/angular/src/demo/welcome.component.ts 0% <ø> (ø) ⬆️
lib/addons/src/make-decorator.ts 100% <ø> (ø) ⬆️
addons/backgrounds/src/components/ColorIcon.tsx 0% <ø> (ø) ⬆️
lib/theming/src/global.ts 0% <0%> (ø) ⬆️
.../storyshots-core/src/frameworks/angular/helpers.ts 0% <0%> (ø) ⬆️
.../backgrounds/src/containers/BackgroundSelector.tsx 0% <0%> (ø) ⬆️
lib/ui/src/keyboard/platform.ts 0% <0%> (ø) ⬆️
addons/actions/src/preview/withActions.ts 37.83% <0%> (-1.06%) ⬇️
lib/ui/src/keyboard/scanCode.ts 0% <0%> (ø) ⬆️
app/angular/src/client/preview/angular/helpers.ts 38.63% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745b6eb...611e582. Read the comment docs.

@shilman shilman merged commit baa9c2c into next Mar 9, 2019
@shilman shilman deleted the tech/prettier-sync branch March 9, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants