Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Added suppport for non-latin story names/IDs #5963

Closed
wants to merge 2 commits into from

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 8, 2019

Issue: #5876

What I did

Added back support for non-latin story names/IDs using slugify

How to test

yarn jest --testPathPattern id.js

@shilman shilman added bug core patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 8, 2019
@shilman shilman added this to the 5.0.x milestone Mar 8, 2019
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #5963 into next will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##            next    #5963      +/-   ##
=========================================
+ Coverage   34.9%   34.99%   +0.08%     
=========================================
  Files        648      648              
  Lines       9500     9482      -18     
  Branches    1345     1360      +15     
=========================================
+ Hits        3316     3318       +2     
+ Misses      5567     5534      -33     
- Partials     617      630      +13
Impacted Files Coverage Δ
lib/router/src/utils.ts 58.06% <100%> (+2.89%) ⬆️
addons/knobs/src/registerKnobs.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Info.tsx
addons/a11y/src/components/Report/Tags.tsx
addons/a11y/src/components/Report/index.tsx
addons/a11y/src/components/Report/Rules.tsx
addons/a11y/src/components/ColorBlindness.tsx
addons/a11y/src/components/A11YPanel.tsx
addons/a11y/src/components/Report/Elements.tsx
addons/a11y/src/components/Tabs.tsx
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1428788...5435572. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't love the breaking change but I think it's best we can do.

Can you add a non-latin test case?

@shilman
Copy link
Member Author

shilman commented Mar 8, 2019

I'm closing this in favor of an approach that simply eliminates punctuation but preserves unicode characters. #5964

@shilman shilman closed this Mar 8, 2019
@shilman shilman deleted the 5876-non-latin-story-names branch March 8, 2019 09:26
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants