-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move react-select
dependency to 2.2
#5867
Conversation
Version 2.3 went from emotion 10 to emotion 9, causing issues with code dedupe for us (since yarn decided to hoist differently). 2.3 is still en semver range here, but this allows us to lock down the older version
This pull request is automatically deployed with Now. |
Deployment failed with the following error:
|
Deployment failed with the following error:
|
Codecov Report
@@ Coverage Diff @@
## next #5867 +/- ##
=======================================
Coverage 35.01% 35.01%
=======================================
Files 648 648
Lines 9480 9480
Branches 1360 1333 -27
=======================================
Hits 3319 3319
Misses 5532 5532
Partials 629 629 Continue to review full report at Codecov.
|
Yeah you're right, this package is huge, I noticed this too when debugging. Would love to switch to something lighter! |
If this frees up your upgrade path, I'm ok with having a lower version of this package for a while! |
Thank you! |
I haven't tested it, but maybe https://ui.reach.tech/menu-button could do the trick for you? |
Issue:
Version 2.3 went from emotion 10 to emotion 9, causing issues with code dedupe for us (since yarn decided to hoist differently).
2.3 is still en semver range here, but this allows us to lock down the older version.
We're stuck on
alpha.5
due to the upgrade that landed in alpha 6See JedWatson/react-select#3346
What I did
Lowered the version in package.json.
An alternative plan is to not use a lib that's larger than react-dom just to render a dropdown in an addon 😛
How to test
Not much to test