-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate addon backgrounds to TS #5535
Migrate addon backgrounds to TS #5535
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
title: string; | ||
onClick: () => void; | ||
value: string; | ||
right?: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes at https://github.com/storybooks/storybook/pull/5535/files#diff-f01e7bd996316ee937af51de4ab40f37R30 are not quite the same as the original. The original would be right? any
, while yours is actually right: any
since you're always setting the right
property.
Also: Do we not have config in place to type this as a React/JSX element?
Codecov Report
@@ Coverage Diff @@
## next #5535 +/- ##
=========================================
- Coverage 33.1% 33.05% -0.06%
=========================================
Files 638 640 +2
Lines 9264 9279 +15
Branches 1318 1346 +28
=========================================
Hits 3067 3067
- Misses 5571 5597 +26
+ Partials 626 615 -11
Continue to review full report at Codecov.
|
@gaetanmaisse I invited you to the Storybook organisation on GitHub, Would you be able to join our discord to chat? |
@ndelangen @gaetanmaisse @tmeasday FYI I'm going to release this in 5.0 since it's blocking a couple PRs. I'd rather not release it because it was merged after "feature freeze" but i think it's faster to merge than to stick to principle on this one. |
…unds Migrate addon backgrounds to TS
Issue:
#5030
What I did
@storybook/addon-backgrounds
to TypeScriptsrc/Tool.js
tocontainers/BackgroundSelector.ts
ColorIcon
in its own filecomponents/ColorIcon.ts