FIX for image-snapshot being broken && FIX snapshots #5457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
danielduan,
Hypnosphi,
tmeasday and
usulpro
as code owners
ndelangen
force-pushed
the
tech/fix-image-snapshot
branch
from
a174ac0 to
5dd4f0d
Compare
…ile://) && FIX snapshots
ndelangen
force-pushed
the
tech/fix-image-snapshot
branch
from
5dd4f0d to
e64dfac
Compare
tmeasday
force-pushed
the
tech/fix-image-snapshot
branch
from
ad8b053 to
e64dfac
Compare
Codecov Report
@@ Coverage Diff @@
## next #5457 +/- ##
=======================================
Coverage 31.38% 31.38%
=======================================
Files 635 635
Lines 9190 9190
Branches 1271 1292 +21
=======================================
Hits 2884 2884
Misses 5666 5666
Partials 640 640
Continue to review full report at Codecov.
|
|
@ndelangen could be a memory issue but here is what chrome logs: https://circleci.com/gh/storybooks/storybook/95407 Googling implied maybe it was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by actually serving content (no file://)