Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add Jest implementation for Storybook #5003

Conversation

abdallahalsamman
Copy link

Issue: #4996

What I did

I added a runner for jest that tests stories and takes snapshots of them automagically.

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? YES
  • Does this need an update to the documentation? YES

If your answer is yes to any of these, please make sure to include it in your PR.

@igor-dv
Copy link
Member

igor-dv commented Dec 15, 2018

I don't see a benefit of having it in the monorepo. It's not an addon 🤷‍♂️

@abdallahalsamman
Copy link
Author

@igor-dv that's right I added the PR here, since this repo is where the issue is actually created.

once I'm done with it I'll push it to it's own repo 🙏

@abdallahalsamman
Copy link
Author

This PR's changes are pushed to https://github.com/storybooks/jest-storybook

@abdallahalsamman abdallahalsamman changed the title [WIP] feature: add Jest implementation for Storybook feature: add Jest implementation for Storybook Dec 16, 2018
@stale stale bot added the inactive label Jan 6, 2019
@storybookjs storybookjs deleted a comment from stale bot Jan 18, 2019
@stale
Copy link

stale bot commented Feb 17, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants