-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add support for Flow to @addons/storysource #4971
Feat: Add support for Flow to @addons/storysource #4971
Conversation
Codecov Report
@@ Coverage Diff @@
## next #4971 +/- ##
==========================================
+ Coverage 35.06% 35.11% +0.04%
==========================================
Files 563 564 +1
Lines 6975 6978 +3
Branches 934 935 +1
==========================================
+ Hits 2446 2450 +4
+ Misses 4034 4033 -1
Partials 495 495
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can you please add some flow usecase to https://github.com/storybooks/storybook/blob/next/addons/storysource/src/loader/inject-decorator.test.js?
I have added unit tests for the flow usecase and the code coverage looks good now. |
Can you please merge from the |
I merged in next for you |
@igor-dv Do you feel strongly about #4971 (review) ? We could merge this and add the use-case later? I'll leave it up to you to merge. |
The tests were added so 👌 |
Issue: Feat: #4955
What I did
Add
Prettier
Flow parser to@addons/storysource
flow
is now an available option for parser under theloader
optionsHow to test
I added some flow type annotations to a few kitchen sink app stories to ensure that storybook was able to launch and storysource was able to parse Flow's syntax.
Is this testable with Jest or Chromatic screenshots?
Can create a mock file to test the inject decorator with flow stories
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
Yes, include flow as an available option.
If your answer is yes to any of these, please make sure to include it in your PR.