Core - do not mangle on production build #4838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #4838 +/- ##
==========================================
- Coverage 35.45% 35.45% -0.01%
==========================================
Files 560 560
Lines 6845 6846 +1
Branches 919 919
==========================================
Hits 2427 2427
- Misses 3934 3935 +1
Partials 484 484
Continue to review full report at Codecov.
|
igor-dv
added
patch:yes
kroeder
reviewed
Nov 24, 2018
shilman
approved these changes
Nov 24, 2018
shilman
pushed a commit
that referenced
this pull request
Nov 26, 2018
Core - do not mangle on production build
shilman
pushed a commit
that referenced
this pull request
Nov 26, 2018
Core - do not mangle on production build
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#4717
#4759
What I did
So, the "production" mode is adding by default the "terser-webpack-plugin" minimizer that mangles by default, and it breaks the info addon.
We need to turn the mangling off.