Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core]: widen airbnb-js-shims dep range #4189

Merged
merged 1 commit into from
Sep 17, 2018
Merged

[core]: widen airbnb-js-shims dep range #4189

merged 1 commit into from
Sep 17, 2018

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Sep 17, 2018

Partially addresses #3955.

@ljharb ljharb mentioned this pull request Sep 17, 2018
Closed
@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS

@ljharb ljharb mentioned this pull request Sep 17, 2018
Merged
@shilman shilman added maintenance User-facing maintenance tasks dependencies and removed maintenance User-facing maintenance tasks labels Sep 17, 2018
@shilman shilman self-assigned this Sep 17, 2018
shilman
shilman approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@shilman shilman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will update CLI tests after the merge

@shilman shilman merged commit 99d9288 into storybookjs:master Sep 17, 2018
@ljharb ljharb deleted the patch-1 branch September 17, 2018 21:54
@ljharb
Copy link
Contributor Author

ljharb commented Sep 17, 2018

Thank you!

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #4189 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4189   +/-   ##
=======================================
  Coverage   40.59%   40.59%           
=======================================
  Files         492      492           
  Lines        5833     5833           
  Branches      780      780           
=======================================
  Hits         2368     2368           
  Misses       3089     3089           
  Partials      376      376

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c14b250...3bbda14. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx alterx is a code owner

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@tmeasday tmeasday Awaiting requested review from tmeasday tmeasday is a code owner

Assignees

@shilman shilman

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljharb @storybook-safe-bot @shilman