Updating react-split-pane to version 0.1.84 #4153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuweiweiwu
requested review from
Hypnosphi,
ndelangen and
tmeasday
as code owners
igor-dv
approved these changes
Sep 10, 2018
|
Definitely fixes the problem I had! Dragging still feels a tiny bit laggy but probably no worse that the current behaviour on storybook alpha <20 (ie. the 0.1.82 version) Thanks @wuweiweiwu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
closes: #4147
see #3965 (comment) for context
cc: @tmeasday
What I did
Updated
react-split-paneto releasev0.1.84https://github.com/tomkp/react-split-pane/releases/tag/v0.1.84How to test
load the official storybook and check that dragging windows resizes correctly. In the options section, check that clicking the hide panel story works as intended.
Is this testable with Jest or Chromatic screenshots? NA
Does this need a new example in the kitchen sink apps? NA
Does this need an update to the documentation? NA
If your answer is yes to any of these, please make sure to include it in your PR.
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]