start-storybook: open browser tab on first compilation #4149

Hypnosphi · 2018-09-09T15:10:11Z

norbert [11:35 AM]
@hypnos next up the auto-open browser feature?

How to test

Run yarn start

igor-dv · 2018-09-09T16:22:01Z

lib/core/src/server/build-dev.js

@@ -153,6 +155,8 @@ Would you like to run Storybook on port ${port} instead?`,
    logger.info(`Storybook started on => ${chalk.cyan(address)}\n`);
    if (program.smokeTest) {
      process.exit(stats.toJson().warnings.length ? 1 : 0);
+    } else {
+      opn(address);


A lot of users are using SB dev mode in CI. I would say that this should be opt-out

codecov · 2018-09-09T23:04:20Z

Codecov Report

Merging #4149 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4149      +/-   ##
==========================================
- Coverage   40.46%   40.45%   -0.02%     
==========================================
  Files         491      491              
  Lines        5839     5841       +2     
  Branches      792      792              
==========================================
  Hits         2363     2363              
- Misses       3088     3090       +2     
  Partials      388      388

Impacted Files	Coverage Δ
lib/core/src/server/build-dev.js	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f61a2f...c2489e0. Read the comment docs.

tmeasday · 2018-09-09T23:13:51Z

MIGRATION.md

@@ -88,6 +88,10 @@ Storybook now uses Babel 7. There's a couple of cases when it can break with you
    ```
  * If you're using Babel 6, make sure that you have direct dependencies on `babel-core@6` and `babel-loader@7`.

+### start-storybook opens browser automatically
+
+If you're using `start-storybook` on CI, you may need to opt out of this using the new `--ci` flag.


Maybe check for process.env.CI too? It's set by most CI systems

I actually think that ci is too limiting

yep. it would be much better to have something like BROWSER=none start-storybook. This is the same, that is used by cra or docusaurus.

gabrielcsapo · 2018-09-10T06:46:01Z

package.json

@@ -53,7 +53,7 @@
    "postpublish": "yarn --cwd lib/cli test -o",
    "publish:alpha": "npm run publish -- --npm-tag=alpha",
    "repo-dirty-check": "node ./scripts/repo-dirty-check",
-    "start": "npm --prefix examples/official-storybook run storybook",
+    "start": "yarn --cwd examples/official-storybook storybook",


does this require people to have yarn installed?

not really, I believe this is only applicable to the storybook project itself

does this require people to have yarn installed?

You need it anyway when you contribute to storybook, see CONTRIBUTING.md

libetl · 2018-09-10T07:47:23Z

Devs restarting locally their already opened storybook will have to provide --ci, which might not be the most meaningful parameter name. WDYT ? (somethink containing 'skip' or 'browser' could be easier to understand)

Hypnosphi · 2018-09-10T08:48:14Z

I don't think that opening more than one tab is so much a problem. CRA tries to solve it on OS X this using appleScript.

The problem is, it opens Google Chrome regardless of which browser user has as default. I don't think we should do it unless Google acquires us.

libetl · 2018-09-10T09:01:21Z

I have been using react-scripts and I can tell that in windows/linux, it opens a new tab for each start command issued, which can be disturbing.
Ok, so I guess the situation cannot be improved today.

ndelangen · 2018-09-11T00:33:18Z

I think it's worth it Yes I've had like 10 tabs open with the same dev setup once.. Thats' not great, but overall I think the experience is better then not having anything opened at all.

Thanks @Hypnosphi 👍👍👍

einarlove · 2018-10-02T21:11:23Z

I'm on alpha.23 and it opens a new tab every time i restart storybook, regardless if I already have it open. I've used react-dev-utils/openBrowser.js before, and it uses opn like this pull-request adds, but also check with AppleScript if there is a tab already open.

Hypnosphi · 2018-10-06T12:42:02Z

The problem is, it opens Google Chrome regardless of which browser user has as default. I don't think we should do it unless Google acquires us.

ndelangen · 2018-10-11T12:19:51Z

@einarlove question:
Why do you need to restart storybook so many times?

I mean -I- do restart it all the time, so i know there are use cases. But mine is I maintain storybook's code...

I'd like to know what's yours. Perhaps you don't need to restart storybook all the time?

If you have multiple storybooks you can run them on a different port

If storybook breaks down somehow and the only fix is a restart, let's fix it?

einarlove · 2018-10-11T12:28:50Z

I always have it running and switching between branches might break it after a while. Suddenly there's a conflict in package.json and etc, and a restart might be required to get it up to speed again.

That's at least my experience. Maybe I'm overdoing it?

ndelangen · 2018-10-11T12:35:12Z

Hmm, no that sounds like it could be quite common.

I guess our CLI could be smarter about broken code and recovering afterwards.

start-storybook: open browser tab on first compilation

6312284

Hypnosphi added feature request core labels Sep 9, 2018

Hypnosphi requested a review from ndelangen September 9, 2018 15:10

Hypnosphi requested review from alterx, igor-dv and tmeasday as code owners September 9, 2018 15:10

igor-dv reviewed Sep 9, 2018

View reviewed changes

Hypnosphi added 2 commits September 10, 2018 01:01

Introduse --ci option

5364ac7

Migration guide

c2489e0

Hypnosphi requested a review from shilman as a code owner September 9, 2018 23:04

tmeasday reviewed Sep 9, 2018

View reviewed changes

gabrielcsapo reviewed Sep 10, 2018

View reviewed changes

libetl approved these changes Sep 10, 2018

View reviewed changes

Hypnosphi merged commit a848486 into master Sep 10, 2018

Hypnosphi deleted the open-tab branch September 10, 2018 09:22

This was referenced Nov 1, 2018

Update @storybook/addons in / from 3.3.11 to 4.0.2 leonardofaria/leozera-ui#241

Closed

Update @storybook/react in / from 3.3.11 to 4.0.2 leonardofaria/leozera-ui#242

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

start-storybook: open browser tab on first compilation #4149

start-storybook: open browser tab on first compilation #4149

Hypnosphi commented Sep 9, 2018

igor-dv Sep 9, 2018

Hypnosphi Sep 9, 2018

codecov bot commented Sep 9, 2018

tmeasday Sep 9, 2018

igor-dv Sep 9, 2018

SleepWalker Oct 5, 2018

gabrielcsapo Sep 10, 2018

libetl Sep 10, 2018

Hypnosphi Sep 10, 2018

libetl commented Sep 10, 2018 •

edited

Loading

Hypnosphi commented Sep 10, 2018

libetl commented Sep 10, 2018 •

edited

Loading

ndelangen commented Sep 11, 2018

einarlove commented Oct 2, 2018

Hypnosphi commented Oct 6, 2018

ndelangen commented Oct 11, 2018

einarlove commented Oct 11, 2018

ndelangen commented Oct 11, 2018

start-storybook: open browser tab on first compilation #4149

start-storybook: open browser tab on first compilation #4149

Conversation

Hypnosphi commented Sep 9, 2018

How to test

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Sep 9, 2018

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

libetl commented Sep 10, 2018 • edited Loading

Hypnosphi commented Sep 10, 2018

libetl commented Sep 10, 2018 • edited Loading

ndelangen commented Sep 11, 2018

einarlove commented Oct 2, 2018

Hypnosphi commented Oct 6, 2018

ndelangen commented Oct 11, 2018

einarlove commented Oct 11, 2018

ndelangen commented Oct 11, 2018

libetl commented Sep 10, 2018 •

edited

Loading

libetl commented Sep 10, 2018 •

edited

Loading