Support .storybook/babel.config.js
#4084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
requested review from
alterx,
igor-dv,
ndelangen,
shilman,
stijnkoopal and
tmeasday
as code owners
igor-dv
reviewed
Aug 27, 2018
There was a problem hiding this comment.
I've started to work on presets and created these initial PRs #4027 #4043 (and also presets-merge-babel-configs branch). Considering this (and if everybody agrees with the API), maybe we can wait with this PR? If it will be released in v4, we won't be able to deprecate it in the next release
| } else { | ||
| try { | ||
| // eslint-disable-next-line import/no-dynamic-require,global-require | ||
| const jsConfig = require(path.resolve(babelConfigDir, 'babel.config.js')); |
There was a problem hiding this comment.
I think it's better to use serverRequire to support also babel.config.ts
There was a problem hiding this comment.
Sure, I think I'll just close this one in favor of yours
There was a problem hiding this comment.
Cool =) Would love to hear your thoughts there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2758 (comment)