Marko: fix welcome component #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nm123github
requested review from
Hypnosphi,
ndelangen,
shilman and
stijnkoopal
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3796 +/- ##
=======================================
Coverage 40.98% 40.98%
=======================================
Files 453 453
Lines 5100 5100
Branches 861 861
=======================================
Hits 2090 2090
Misses 2493 2493
Partials 517 517Continue to review full report at Codecov.
|
Hypnosphi
approved these changes
Jun 26, 2018
shilman
changed the title
shilman
changed the title
This was referenced Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix example 'Welcome' component so that getComponent() does not throw Error('No component');
