-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the --use-npm flag also for version checking #3535
Conversation
I think it's ok |
Codecov Report
@@ Coverage Diff @@
## master #3535 +/- ##
==========================================
- Coverage 37.12% 37.11% -0.01%
==========================================
Files 509 509
Lines 10848 10849 +1
Branches 971 973 +2
==========================================
Hits 4027 4027
- Misses 6231 6238 +7
+ Partials 590 584 -6
Continue to review full report at Codecov.
|
Tried to make sure that I didn't miss a generator or call to either |
Ran the tests again and now they succeeded ( |
Please update generators for new apps (html, marko) as well |
Done, I'm not in a position atm to run the tests again though, I can do that in a few hours. |
Use the --use-npm flag also for version checking # Conflicts: # lib/cli/bin/generate.js # lib/cli/generators/HTML/index.js # lib/cli/generators/MARKO/index.js # lib/cli/generators/MITHRIL/index.js
Released as |
Issue: While I was working on #3531, I noticed that the package manager responsible for checking the versions of dependencies in the generators was dependent on
has_yarn
, fully ignoring the--use-npm
flag #3531 (comment).What I did
I made the
latestVersion
function to adhere to the--use-npm
flag.How I currently did it is pass the
npmOptions
object all the way through generators in order to reachlatestVersion
.--use-npm
flag in the helper?