Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move polymer loader to peerDependencies #3161

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Mar 7, 2018

Issue: polymer-webpack-loader adds following line to processed files:

require('polymer-webpack-loader/register-html-template')

It means that the package should always be available on root level. We can't rely on npm hoisting for that, so we need to move it to peerDependencies

@codecov
Copy link

codecov bot commented Mar 7, 2018

Codecov Report

Merging #3161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3161   +/-   ##
=======================================
  Coverage   36.03%   36.03%           
=======================================
  Files         437      437           
  Lines        9464     9464           
  Branches      860      893   +33     
=======================================
  Hits         3410     3410           
+ Misses       5532     5493   -39     
- Partials      522      561   +39
Impacted Files Coverage Δ
app/vue/src/server/utils.js 0% <0%> (-100%) ⬇️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 22.41% <0%> (ø) ⬆️
lib/ui/src/modules/api/index.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/index.js 29.28% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 76.92% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
...tions/src/lib/types/function/createFunctionEval.js 77.77% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
addons/knobs/src/react/WrapStory.js 49.42% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 24.63% <0%> (ø) ⬆️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3140df3...88d2fe2. Read the comment docs.

@ndelangen
Copy link
Member

@stijnkoopal What do you think?

@Hypnosphi Hypnosphi mentioned this pull request Mar 7, 2018
4 tasks
@@ -59,10 +58,12 @@
"webpack-hot-middleware": "^2.21.2"
},
"devDependencies": {
"nodemon": "^1.17.1"
"nodemon": "^1.17.1",
"polymer-webpack-loader": "^2.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that we need this dependency still, but perhaps I'm missing something here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! that doesn't sounds like a blocker tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants