-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move polymer loader to peerDependencies #3161
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3161 +/- ##
=======================================
Coverage 36.03% 36.03%
=======================================
Files 437 437
Lines 9464 9464
Branches 860 893 +33
=======================================
Hits 3410 3410
+ Misses 5532 5493 -39
- Partials 522 561 +39
Continue to review full report at Codecov.
|
@stijnkoopal What do you think? |
@@ -59,10 +58,12 @@ | |||
"webpack-hot-middleware": "^2.21.2" | |||
}, | |||
"devDependencies": { | |||
"nodemon": "^1.17.1" | |||
"nodemon": "^1.17.1", | |||
"polymer-webpack-loader": "^2.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that we need this dependency still, but perhaps I'm missing something here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! that doesn't sounds like a blocker tbh
Issue:
polymer-webpack-loader
adds following line to processed files:It means that the package should always be available on root level. We can't rely on npm hoisting for that, so we need to move it to
peerDependencies