Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon Storysource] Add auto scrolling to the selected story #3025

Merged
merged 5 commits into from
Feb 19, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Feb 19, 2018

Issue: When selecting a story, panel should be scrolled to a selected area in code

What I did

Added an auto-scrolling

@codecov
Copy link

codecov bot commented Feb 19, 2018

Codecov Report

Merging #3025 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3025      +/-   ##
==========================================
- Coverage    37.3%   37.28%   -0.02%     
==========================================
  Files         435      435              
  Lines        9427     9432       +5     
  Branches      912      897      -15     
==========================================
  Hits         3517     3517              
- Misses       5345     5381      +36     
+ Partials      565      534      -31
Impacted Files Coverage Δ
addons/storysource/src/StoryPanel.js 0% <0%> (ø) ⬆️
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-76.67%) ⬇️
.../src/modules/ui/components/stories_panel/header.js 29.62% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/search_box.js 36.36% <0%> (ø) ⬆️
addons/jest/src/hoc/provideJestResult.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/addon_panel/index.js 34.78% <0%> (ø) ⬆️
addons/actions/src/lib/util/getPropertiesList.js 60% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 67.64% <0%> (ø) ⬆️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e026e3...ac33fbd. Read the comment docs.

@igor-dv
Copy link
Member Author

igor-dv commented Feb 19, 2018

If storysource addon will be merged to 3.3, I assume this one is also might be

@Hypnosphi
Copy link
Member

Hypnosphi commented Feb 19, 2018

Agree. Let's wait what @shilman says about the addon itself

@igor-dv
Copy link
Member Author

igor-dv commented Feb 19, 2018

@Hypnosphi , I've added a delay for 2 secs there. Is it still needed after your #3027 ?

@Hypnosphi
Copy link
Member

No, #3027 should replace it

@igor-dv igor-dv merged commit 7844961 into master Feb 19, 2018
@igor-dv igor-dv deleted the addon-stories-scroll-to-selection branch February 19, 2018 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants