Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automigrations: Skip vite config file migration for react native web #30190

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Jan 5, 2025

Closes #

What I did

changed it to skip the vite config migration if the framework is react native web vite

this is because we don't expect a vite config in these projects since they usually rely on metro and storybook runs separately

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.8 MB 77.8 MB -3.23 kB 0.81 0%
initSize 131 MB 131 MB -3.23 kB -1.01 0%
diffSize 53 MB 53 MB 0 B -1.01 0%
buildSize 7.19 MB 7.19 MB 0 B -0.63 0%
buildSbAddonsSize 1.85 MB 1.85 MB 0 B -0.63 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.87 MB 1.87 MB 0 B 0.4 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.91 MB 3.91 MB 0 B -0.63 0%
buildPreviewSize 3.28 MB 3.28 MB 0 B - 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 24.8s 8.5s -16s -296ms -0.56 -190.3%
generateTime 18.5s 21.7s 3.2s 1.05 14.7%
initTime 11.9s 14.2s 2.3s 0.3 16.5%
buildTime 8.7s 8.3s -398ms -0.85 -4.8%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 4.5s 4.2s -294ms -1.44 🔰-6.9%
devManagerResponsive 3.3s 3.2s -131ms -1.29 -4%
devManagerHeaderVisible 574ms 1s 517ms 3.67 🔺47.4%
devManagerIndexVisible 608ms 1s 487ms 3.34 🔺44.5%
devStoryVisibleUncached 2s 1.7s -329ms -0.65 -19.1%
devStoryVisible 609ms 1s 484ms 3.27 🔺44.3%
devAutodocsVisible 543ms 939ms 396ms 3.75 🔺42.2%
devMDXVisible 515ms 858ms 343ms 2.41 🔺40%
buildManagerHeaderVisible 549ms 556ms 7ms -0.65 1.3%
buildManagerIndexVisible 647ms 636ms -11ms -0.75 -1.7%
buildStoryVisible 534ms 538ms 4ms -0.7 0.7%
buildAutodocsVisible 483ms 705ms 222ms 2.32 🔺31.5%
buildMDXVisible 521ms 565ms 44ms 0.82 7.8%

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@dannyhw dannyhw added maintenance User-facing maintenance tasks ci:normal labels Jan 5, 2025
Copy link

nx-cloud bot commented Jan 5, 2025

View your CI Pipeline Execution ↗ for commit 45e96d3.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 36s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-05 15:27:45 UTC

@shilman shilman changed the title RNWVite: Dont run the vite config file migration for react native web RNW-Vite: Dont run the vite config file migration for react native web Jan 5, 2025
@shilman shilman changed the title RNW-Vite: Dont run the vite config file migration for react native web Automigrations: Skip vite config file migration for react native web Jan 5, 2025
@shilman shilman added bug and removed maintenance User-facing maintenance tasks labels Jan 6, 2025
@shilman shilman merged commit 4162860 into next Jan 6, 2025
64 of 68 checks passed
@shilman shilman deleted the danny/rnw-doesnt-require-vite-conf branch January 6, 2025 14:47
@github-actions github-actions bot mentioned this pull request Jan 6, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants