Bun: Add support for text lock file #30160
Open
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 6ec9fbd.
☁️ Nx Cloud last updated this comment at |
valentinpalkovic
changed the title
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
valentinpalkovic
approved these changes
Jan 16, 2025
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 59 | 59 | 0 |
| Self size | 228 KB | 410 KB | 🚨 +183 KB 🚨 |
| Dependency size | 13.46 MB | 13.46 MB | 🎉 -22 B 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-essentials
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 36 | 36 | 0 |
| Self size | 12 KB | 17 KB | 🚨 +4 KB 🚨 |
| Dependency size | 13.83 MB | 13.83 MB | 🚨 +77 B 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-mdx-gfm
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 69 | 69 | 0 |
| Self size | 3 KB | 4 KB | 🚨 +1 KB 🚨 |
| Dependency size | 2.41 MB | 2.41 MB | 🎉 -3 B 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/experimental-addon-test
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 60 | 60 | 0 |
| Self size | 832 KB | 974 KB | 🚨 +142 KB 🚨 |
| Dependency size | 14.15 MB | 14.15 MB | 🎉 -47 B 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/core
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 53 | 53 | 0 |
| Self size | 19.08 MB | 21.45 MB | 🚨 +2.37 MB 🚨 |
| Dependency size | 14.43 MB | 14.43 MB | 🎉 -2 B 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 114 | 105 | 🎉 -9 🎉 |
| Self size | 43 KB | 42 KB | 🎉 -1 KB 🎉 |
| Dependency size | 18.25 MB | 18.06 MB | 🎉 -186 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 54 | 54 | 0 |
| Self size | 22 KB | 22 KB | 🎉 -2 B 🎉 |
| Dependency size | 33.51 MB | 35.88 MB | 🚨 +2.37 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 55 | 55 | 0 |
| Self size | 1 KB | 1 KB | 🎉 -2 B 🎉 |
| Dependency size | 33.54 MB | 35.90 MB | 🚨 +2.37 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 398 | 398 | 0 |
| Self size | 503 KB | 496 KB | 🎉 -7 KB 🎉 |
| Dependency size | 75.56 MB | 77.93 MB | 🚨 +2.37 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 276 | 276 | 0 |
| Self size | 612 KB | 612 KB | 🎉 -2 B 🎉 |
| Dependency size | 65.36 MB | 67.73 MB | 🚨 +2.37 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/core-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 1 | 3 | 🚨 +2 🚨 |
| Self size | 16 KB | 16 KB | 🎉 -2 B 🎉 |
| Dependency size | 28 KB | 2.40 MB | 🚨 +2.37 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 112 | 112 | 0 |
| Self size | 1.11 MB | 1.11 MB | 🎉 -2 B 🎉 |
| Dependency size | 42.65 MB | 45.02 MB | 🚨 +2.37 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-preact-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 2 | 4 | 🚨 +2 🚨 |
| Self size | 5 KB | 5 KB | 🎉 -3 B 🎉 |
| Dependency size | 44 KB | 2.42 MB | 🚨 +2.37 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-server-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 18 | 20 | 🚨 +2 🚨 |
| Self size | 10 KB | 10 KB | 🎉 -4 B 🎉 |
| Dependency size | 1.48 MB | 3.85 MB | 🚨 +2.37 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-svelte-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 101 | 103 | 🚨 +2 🚨 |
| Self size | 14 KB | 14 KB | 🎉 -3 B 🎉 |
| Dependency size | 10.40 MB | 12.77 MB | 🚨 +2.37 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Recently bun added support for text lock files, so now project with bun can have
bun.lockand/orbun.lockb.I updated checks to include both options.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
I did not test it because I have no idea how to test installer scripts. It would not hurt if somebody could test it, but currently changes are so minor and follow existing code letter to letter that I most likely broke nothing.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Added support for Bun's text-based lock files in package manager detection, allowing both
bun.lockandbun.lockbformats in Storybook's package manager factory.BUN_LOCKFILEconstant for text lock file incode/core/src/common/js-package-manager/JsPackageManagerFactory.tsBUN_LOCKFILE_BINARYfor binary format💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!