Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: Replace react-confetti with @neoconfetti/react #30098

Merged
merged 9 commits into from
Dec 19, 2024
+118 −230
Merged

Onboarding: Replace react-confetti with @neoconfetti/react #30098

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6603753
use react-confetti source to prevent https://github.com/storybookjs/s…
ndelangen Dec 18, 2024
cc2a84a
Add E2E tests
ndelangen Dec 18, 2024
9a0f2fd
Addon Onboarding: Replace react-confetti with react-confetti-boom
yannbf Dec 18, 2024
792ac4c
Add a wrapper
yannbf Dec 18, 2024
2a69d26
Merge branch 'next' into norbert/fix-confetti-bundling
yannbf Dec 18, 2024
2b2b54d
rename e2e test
yannbf Dec 18, 2024
441ad86
skip onboarding addon tests for built storybooks
yannbf Dec 18, 2024
717e256
use @neoconfetti/react instead
yannbf Dec 18, 2024
f202d2a
Merge pull request #30100 from storybookjs/norbert/fix-confetti-bundl…
yannbf Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/addons/onboarding/src/components/Confetti/Confetti.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { createPortal } from 'react-dom';

import { styled } from 'storybook/internal/theming';

import ReactConfetti from 'react-confetti';
import { ReactConfetti } from 'react-confetti/src/ReactConfetti';

interface ConfettiProps extends Omit<React.ComponentProps<typeof ReactConfetti>, 'drawShape'> {
top?: number;
Expand Down
Loading