-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon Test: Clear coverage data when starting or watching #30072
Conversation
…version range handling
Due to the following issue nrwl/nx#28806, which we encounter in the GitHub Window Unit Test Job regularly, we have to opt-in to NX's legacy cache mechanism. That will use the file system instead of a file DB for caching.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fc703e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
102 file(s) reviewed, 13 comment(s)
Edit PR Review Bot Settings | Greptile
Supersedes #30062
What I did
This clears the coverage data when starting a new test run or enabling watch mode, in order to prevent stale coverage data from lingering.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
Based on the provided files and changes, I'll create a concise summary of this PR:
This PR enhances the test addon to clear coverage data when starting new test runs or enabling watch mode, preventing stale coverage information from persisting between test sessions.
code/addons/test/src/manager.tsx
to properly clear coverage data on test start/watchdocs/writing-tests/test-coverage.mdx
with Vitest 3.0.0 referencestest-storybooks/portable-stories-kitchen-sink/react/.storybook/main.ts
scripts/task.ts
with helpful task name suggestionsuseLegacyCache: "true"
tocode/nx.json
for build system compatibility