Build: Refactor e2e test for composition to make it more stable

[valentinpalkovic]

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name	before	after	diff	z	%
createSize	0 B	0 B	0 B	-	-
generateSize	77.7 MB	77.7 MB	0 B	2	0%
initSize	136 MB	136 MB	0 B	2	0%
diffSize	58.4 MB	58.4 MB	0 B	2	0%
buildSize	7.24 MB	7.24 MB	0 B	1.53	0%
buildSbAddonsSize	1.88 MB	1.88 MB	0 B	1.53	0%
buildSbCommonSize	195 kB	195 kB	0 B	-	0%
buildSbManagerSize	1.86 MB	1.86 MB	0 B	1.37	0%
buildSbPreviewSize	0 B	0 B	0 B	-	-
buildStaticSize	0 B	0 B	0 B	-	-
buildPrebuildSize	3.93 MB	3.93 MB	0 B	1.53	0%
buildPreviewSize	3.3 MB	3.3 MB	0 B	1.48	0%
testBuildSize	0 B	0 B	0 B	-	-
testBuildSbAddonsSize	0 B	0 B	0 B	-	-
testBuildSbCommonSize	0 B	0 B	0 B	-	-
testBuildSbManagerSize	0 B	0 B	0 B	-	-
testBuildSbPreviewSize	0 B	0 B	0 B	-	-
testBuildStaticSize	0 B	0 B	0 B	-	-
testBuildPrebuildSize	0 B	0 B	0 B	-	-
testBuildPreviewSize	0 B	0 B	0 B	-	-

name	before	after	diff	z	%
createTime	6.9s	6.9s	7ms	-0.84	0.1%
generateTime	19.6s	19.4s	-218ms	-0.81	-1.1%
initTime	12.9s	12.7s	-250ms	-1.06	-2%
buildTime	11s	7.9s	-3s -100ms	-0.94	-38.8%
testBuildTime	0ms	0ms	0ms	-	-
devPreviewResponsive	4.7s	4.4s	-291ms	-1.01	-6.5%
devManagerResponsive	3.5s	3.3s	-213ms	-1.04	-6.3%
devManagerHeaderVisible	657ms	509ms	-148ms	-0.9	-29.1%
devManagerIndexVisible	693ms	537ms	-156ms	-1.26	🔰-29.1%
devStoryVisibleUncached	1.8s	1.7s	-136ms	-0.12	-7.9%
devStoryVisible	715ms	538ms	-177ms	-1.24	🔰-32.9%
devAutodocsVisible	559ms	461ms	-98ms	-0.87	-21.3%
devMDXVisible	564ms	466ms	-98ms	-0.7	-21%
buildManagerHeaderVisible	612ms	500ms	-112ms	-1.06	-22.4%
buildManagerIndexVisible	698ms	589ms	-109ms	-1.06	-18.5%
buildStoryVisible	563ms	462ms	-101ms	-1	-21.9%
buildAutodocsVisible	444ms	402ms	-42ms	-0.63	-10.4%
buildMDXVisible	529ms	383ms	-146ms	-0.88	-38.1%

Greptile Summary

Based on the provided information, I'll create a concise summary of the changes in this pull request:

Improved stability of composition end-to-end tests by refining iframe element selection and verification methods, particularly for composed Storybook instances.

• Modified verification of 7.6.18 badge component to check for 'Default' text within iframe content frame
• Added 15 second timeout for iframe content verification to handle loading delays
• Inconsistency exists between desktop/mobile test selectors that could affect stability
• Tests now verify both 8.0.0 and 7.6.18 Storybook instances are properly composed
• Tests validate search functionality and story rendering across composed instances

The changes focus on making the e2e tests more reliable by improving how elements are located and verified within iframes, though there's still room for consistency improvements between desktop and mobile test implementations.

[greptile-apps]

LGTM

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8686c4e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many -t build --parallel=3

---

Sent with 💌 from NxCloud.