Release: Prerelease 8.5.0-alpha.22 #30041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Next.js overrides certain internal webpack packages (particularly `webpack-sources`), which are involved with filesystem caching, with its own versions from next/dist/compiled. For filesystem caching to work, Next.js must be allowed to perform these overrides before webpack is first initialized by @storybook/builder-webpack5. If it is not, the objects to be serialized to disk in the caching process will be instantiated using the original (non-Next.js) modules, but the serializers will be created using the Next.js modules. This mismatch between the objects to be cached and the serializers that write the filesystem cache prevents the cache from being written; instead, webpack outputs a warning message to the console for every object that it tries and fails to find a matching serializer for. This fix works by invoking Next.js to configure webpack in the `core` hook of @storybook/nextjs/preset, immediately before loading @storybook/builder-webpack5. We don't actually use this configuration that Next.js creates; the actual configuration that will be used in the build is still generated in `webpackFinal` as before. `fsCache` has a large impact on Storybook build performance. Even in a minimal project with a single story, enabling it reduces build time by 66%! This is therefore a very valuable option to be able to enable. Fixes #29621
…-rehype Addon Docs: Dynamically import rehype
…etection-for-vitest Addon Test: Set environment variable for Vitest to indicate Storybook integration
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.21
branch
from
156caba to
0f5f793
Compare
React: Fix RSC compatibility with addon-themes
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.21
branch
from
0f5f793 to
ce73fd9
Compare
Nextjs-Vite: Fix docgen types in main config
…executor Angular: Support statsJson in angular schemas
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.21
branch
from
ce73fd9 to
be2b253
Compare
Next.js: Fix webpack fsCache not working
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.21
branch
from
be2b253 to
f83cdc4
Compare
…ontrols UI: Fix controls and parameters on tag-filtered stories
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.21
branch
from
f83cdc4 to
8d34b1b
Compare
…e-panel Docs: Add code snippet to addons panel
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.21
branch
from
8d34b1b to
d746e14
Compare
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.21
branch
from
d746e14 to
42b895d
Compare
shilman
added
freeze
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 42b895d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 7 | 7 | 0 |
| Self size | 1.89 MB | 1.89 MB | 0 B |
| Dependency size | 10.54 MB | 10.69 MB | 🚨 +156 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/builder-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 230 | 234 | 🚨 +4 🚨 |
| Self size | 79 KB | 79 KB | 0 B |
| Dependency size | 29.77 MB | 31.03 MB | 🚨 +1.27 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/core
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 49 | 50 | 🚨 +1 🚨 |
| Self size | 21.44 MB | 21.44 MB | 🚨 +3 KB 🚨 |
| Dependency size | 14.34 MB | 14.36 MB | 🚨 +16 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/angular
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 265 | 261 | 🎉 -4 🎉 |
| Self size | 362 KB | 363 KB | 🚨 +970 B 🚨 |
| Dependency size | 34.66 MB | 33.56 MB | 🎉 -1.10 MB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/ember
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 257 | 253 | 🎉 -4 🎉 |
| Self size | 22 KB | 22 KB | 0 B |
| Dependency size | 32.17 MB | 31.06 MB | 🎉 -1.10 MB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/experimental-nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 87 | 153 | 🚨 +66 🚨 |
| Self size | 231 KB | 231 KB | 🚨 +16 B 🚨 |
| Dependency size | 31.57 MB | 44.67 MB | 🚨 +13.10 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/html-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 240 | 244 | 🚨 +4 🚨 |
| Self size | 6 KB | 6 KB | 0 B |
| Dependency size | 30.31 MB | 31.58 MB | 🚨 +1.27 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 593 | 589 | 🎉 -4 🎉 |
| Self size | 466 KB | 471 KB | 🚨 +5 KB 🚨 |
| Dependency size | 84.29 MB | 83.19 MB | 🎉 -1.10 MB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/preact-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 238 | 242 | 🚨 +4 🚨 |
| Self size | 6 KB | 6 KB | 0 B |
| Dependency size | 29.89 MB | 31.16 MB | 🚨 +1.27 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 316 | 320 | 🚨 +4 🚨 |
| Self size | 6 KB | 6 KB | 0 B |
| Dependency size | 41.05 MB | 42.32 MB | 🚨 +1.27 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/server-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 248 | 252 | 🚨 +4 🚨 |
| Self size | 14 KB | 14 KB | 0 B |
| Dependency size | 31.29 MB | 32.56 MB | 🚨 +1.27 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/svelte-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 303 | 307 | 🚨 +4 🚨 |
| Self size | 6 KB | 6 KB | 0 B |
| Dependency size | 37.88 MB | 39.15 MB | 🚨 +1.27 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/vue3-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 489 | 493 | 🚨 +4 🚨 |
| Self size | 6 KB | 6 KB | 0 B |
| Dependency size | 54.29 MB | 55.55 MB | 🚨 +1.27 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/web-components-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 238 | 242 | 🚨 +4 🚨 |
| Self size | 5 KB | 5 KB | 0 B |
| Dependency size | 29.94 MB | 31.20 MB | 🚨 +1.27 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 50 | 51 | 🚨 +1 🚨 |
| Self size | 22 KB | 22 KB | 0 B |
| Dependency size | 35.78 MB | 35.80 MB | 🚨 +19 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 51 | 52 | 🚨 +1 🚨 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 35.80 MB | 35.82 MB | 🚨 +19 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 392 | 393 | 🚨 +1 🚨 |
| Self size | 493 KB | 493 KB | 0 B |
| Dependency size | 77.38 MB | 77.56 MB | 🚨 +175 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 272 | 273 | 🚨 +1 🚨 |
| Self size | 612 KB | 612 KB | 0 B |
| Dependency size | 67.38 MB | 67.55 MB | 🚨 +175 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 108 | 109 | 🚨 +1 🚨 |
| Self size | 1.11 MB | 1.11 MB | 0 B |
| Dependency size | 44.91 MB | 44.93 MB | 🚨 +19 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/source-loader
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 5 | 5 | 0 |
| Self size | 41 KB | 41 KB | 0 B |
| Dependency size | 10.48 MB | 10.64 MB | 🚨 +156 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-html-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 93 | 102 | 🚨 +9 🚨 |
| Self size | 4 KB | 4 KB | 0 B |
| Dependency size | 20.23 MB | 22.71 MB | 🚨 +2.48 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-react-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 182 | 191 | 🚨 +9 🚨 |
| Self size | 24 KB | 24 KB | 0 B |
| Dependency size | 30.99 MB | 33.47 MB | 🚨 +2.48 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-vue3-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 369 | 378 | 🚨 +9 🚨 |
| Self size | 9 KB | 9 KB | 0 B |
| Dependency size | 45.16 MB | 47.64 MB | 🚨 +2.48 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.5.0-alpha.21to8.5.0-alpha.22.Once this pull request is merged, it will trigger a new release of version
8.5.0-alpha.22.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:scrollIntoViewbehavior and reimplement testing module time rendering #30044test.includepatterns #30029If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-alpha.22
test.includepatterns - #30029, thanks @JReinhold!scrollIntoViewbehavior and reimplement testing module time rendering - #30044, thanks @ghengeveld!