Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon A11y: Update accessibility status handling in TestProviderRender #30027

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Dec 11, 2024

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.7 MB 77.7 MB 0 B 1.36 0%
initSize 133 MB 133 MB 0 B 0.45 0%
diffSize 55.1 MB 55.1 MB 0 B 0.42 0%
buildSize 6.87 MB 6.87 MB 0 B 0.54 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B 0.45 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB 0 B 0.57 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.57 MB 3.57 MB 0 B 0.54 0%
buildPreviewSize 3.3 MB 3.3 MB 0 B 0.53 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 6.4s 8.2s 1.7s -0.18 21.2%
generateTime 18.7s 24.8s 6.1s 1.83 🔺24.7%
initTime 12.1s 16.2s 4s 1.23 25.2%
buildTime 10.5s 9.1s -1s -447ms -0.57 -15.8%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.2s 4.4s -833ms -1.61 🔰-18.8%
devManagerResponsive 3.6s 3.3s -329ms -1.57 🔰-9.8%
devManagerHeaderVisible 540ms 499ms -41ms -1.26 🔰-8.2%
devManagerIndexVisible 572ms 572ms 0ms -0.82 0%
devStoryVisibleUncached 1.8s 1.5s -299ms -0.79 -19.1%
devStoryVisible 570ms 531ms -39ms -1.3 🔰-7.3%
devAutodocsVisible 492ms 502ms 10ms -0.76 2%
devMDXVisible 504ms 453ms -51ms -1.5 🔰-11.3%
buildManagerHeaderVisible 547ms 564ms 17ms -0.54 3%
buildManagerIndexVisible 654ms 646ms -8ms -0.63 -1.2%
buildStoryVisible 506ms 522ms 16ms -0.41 3.1%
buildAutodocsVisible 426ms 386ms -40ms -1.29 🔰-10.4%
buildMDXVisible 420ms 377ms -43ms -1.59 🔰-11.4%

Greptile Summary

Based on the provided information, I'll create a concise summary of the changes in the TestProviderRender component focusing on accessibility status handling:

Updates TestProviderRender component to improve accessibility status handling during test execution, ensuring more accurate status representation in the Storybook UI.

  • Sets a11yStatus to 'unknown' when tests are running to prevent misleading status display
  • Updates status calculation logic to consistently return 'unknown' during test execution
  • Adds state.running to useMemo dependency arrays for proper status updates
  • Improves synchronization between test execution state and accessibility status display
  • Ensures consistent status behavior across component tests and accessibility checks

@valentinpalkovic valentinpalkovic added bug addon: a11y ci:daily Run the CI jobs that normally run in the daily job. addon: test labels Dec 11, 2024
@valentinpalkovic valentinpalkovic self-assigned this Dec 11, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Dec 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 67bf4f6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic merged commit 7b56f57 into next Dec 11, 2024
108 of 109 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/do-not-show-state-while-running branch December 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: a11y addon: test bug ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants