-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Always cleanup Verdaccio ports before running registry #30023
base: next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
logger.error(e); | ||
rm(join(root, '.npmrc'), { force: true }).then(() => { | ||
process.exit(1); | ||
cleanupVerdaccioProcesses().then(() => { | ||
process.exit(1); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: error handling chain could fail silently if rm() or cleanupVerdaccioProcesses() rejects - should wrap in try/catch
☁️ Nx Cloud ReportCI is running/has finished running commands for commit aefde6b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ba94f06
to
89e2abe
Compare
Closes #
What I did
For years we had issues in the task command where the
run-registry
task would fail with:This PR fixes that issue by killing the processes in the verdaccio ports before running the registry task
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
Added port cleanup functionality to prevent Verdaccio server hanging issues by automatically killing processes on specific ports before starting the registry server.
scripts/utils/kill-port.ts
utility to handle process termination on both Windows and Unix systemsscripts/run-registry.ts
to cleanup ports 6001 and 6002 before starting Verdaccio