Release: Prerelease 8.5.0-alpha.20 #29999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…st-support-preview-html
…adding experimental-addon-test
…st-support-preview-html
… when asking user to migrate
…st-support-preview-html
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
11 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+28
to
+29
| width: `${size}px!important`, | ||
| height: `${size}px!important`, |
There was a problem hiding this comment.
style: !important flag usage here could cause styling conflicts. Consider removing if not absolutely necessary.
| </Circle> | ||
| {running && ( | ||
| <Circle size={size} width={width} xmlns={XMLNS} spinner> | ||
| <circle strokeDashoffset={Math.PI * (size - Math.ceil(width)) * (1 - percentage / 100)} /> |
There was a problem hiding this comment.
style: strokeDashoffset calculation is duplicated on line 86. Consider extracting to a variable or helper function.
Comment on lines
+87
to
+89
| state.progress?.percentageCompleted ?? | ||
| (state.details as any)?.buildProgressPercentage | ||
| } |
There was a problem hiding this comment.
logic: Fallback to buildProgressPercentage may be unsafe - need type checking or default value if both are undefined
… of multiple results
Addon Test: Handle undefined storyId
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.19
branch
from
e53d44c to
1102c68
Compare
…stall-coverage-provider-out-of-the-box Addon Test: Add `@vitest/coverage-v8` during postinstall if no coverage reporter is installed
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.19
branch
from
1102c68 to
7c5d74c
Compare
…custom-vitest-config-support
…rybookjs/storybook into norbert/vitest-support-preview-html
Addon Test: Make component tests status row link to the story's tests panel
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.19
branch
from
7c5d74c to
93dfefe
Compare
… handling and to avoid accessing undefined
Test: Always run Vitest in watch mode internally
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.19
branch
from
93dfefe to
b7929d9
Compare
…ig-support TestAddon: Merge viteFinal config into vitest config
…view-html AddonTest: Add support for previewHead
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.19
branch
from
b7929d9 to
b1f5dca
Compare
Addon Test: Filter out falsy test results in TestProviderRender
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.19
branch
from
b1f5dca to
84cd43e
Compare
…for-experimental-framework AddonTest: Prompt switch to `experimental-nextjs-vite`
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.19
branch
from
84cd43e to
7c376ba
Compare
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.19
branch
from
7c376ba to
28e19d0
Compare
shilman
added
freeze
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 28e19d0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 3 | 59 | 🚨 +56 🚨 |
| Self size | 44 KB | 45 KB | 🚨 +564 B 🚨 |
| Dependency size | 2.80 MB | 13.46 MB | 🚨 +10.65 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-interactions
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 56 | 56 | 0 |
| Self size | 129 KB | 129 KB | 🚨 +9 B 🚨 |
| Dependency size | 12.44 MB | 12.73 MB | 🚨 +287 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/experimental-addon-test
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 61 | 60 | 🎉 -1 🎉 |
| Self size | 695 KB | 958 KB | 🚨 +263 KB 🚨 |
| Dependency size | 13.86 MB | 14.14 MB | 🚨 +285 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/builder-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 223 | 224 | 🚨 +1 🚨 |
| Self size | 79 KB | 79 KB | 0 B |
| Dependency size | 29.64 MB | 29.67 MB | 🚨 +36 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/core
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 46 | 47 | 🚨 +1 🚨 |
| Self size | 19.05 MB | 21.44 MB | 🚨 +2.39 MB 🚨 |
| Dependency size | 14.30 MB | 14.31 MB | 🚨 +15 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/ember
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 250 | 251 | 🚨 +1 🚨 |
| Self size | 22 KB | 22 KB | 0 B |
| Dependency size | 32.04 MB | 32.08 MB | 🚨 +36 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/experimental-nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 87 | 87 | 0 |
| Self size | 231 KB | 231 KB | 0 B |
| Dependency size | 31.28 MB | 31.57 MB | 🚨 +287 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/html-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 233 | 234 | 🚨 +1 🚨 |
| Self size | 6 KB | 6 KB | 0 B |
| Dependency size | 30.19 MB | 30.22 MB | 🚨 +36 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 585 | 586 | 🚨 +1 🚨 |
| Self size | 464 KB | 466 KB | 🚨 +2 KB 🚨 |
| Dependency size | 83.85 MB | 84.17 MB | 🚨 +316 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preact-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 231 | 232 | 🚨 +1 🚨 |
| Self size | 6 KB | 6 KB | 0 B |
| Dependency size | 29.76 MB | 29.80 MB | 🚨 +36 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 102 | 105 | 🚨 +3 🚨 |
| Self size | 41 KB | 42 KB | 🚨 +435 B 🚨 |
| Dependency size | 17.86 MB | 18.01 MB | 🚨 +156 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 309 | 310 | 🚨 +1 🚨 |
| Self size | 6 KB | 6 KB | 0 B |
| Dependency size | 40.93 MB | 40.96 MB | 🚨 +29 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/server-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 241 | 242 | 🚨 +1 🚨 |
| Self size | 14 KB | 14 KB | 0 B |
| Dependency size | 31.17 MB | 31.20 MB | 🚨 +36 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/svelte-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 296 | 297 | 🚨 +1 🚨 |
| Self size | 6 KB | 6 KB | 0 B |
| Dependency size | 37.75 MB | 37.79 MB | 🚨 +37 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/vue3-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 107 | 108 | 🚨 +1 🚨 |
| Self size | 16 KB | 16 KB | 🎉 -99 B 🎉 |
| Dependency size | 42.54 MB | 42.55 MB | 🚨 +14 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/vue3-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 482 | 483 | 🚨 +1 🚨 |
| Self size | 6 KB | 6 KB | 0 B |
| Dependency size | 54.16 MB | 54.19 MB | 🚨 +29 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/web-components-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 231 | 232 | 🚨 +1 🚨 |
| Self size | 5 KB | 5 KB | 0 B |
| Dependency size | 29.81 MB | 29.85 MB | 🚨 +36 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 47 | 48 | 🚨 +1 🚨 |
| Self size | 22 KB | 22 KB | 0 B |
| Dependency size | 33.35 MB | 35.75 MB | 🚨 +2.40 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 48 | 49 | 🚨 +1 🚨 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 33.37 MB | 35.77 MB | 🚨 +2.40 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 388 | 389 | 🚨 +1 🚨 |
| Self size | 484 KB | 493 KB | 🚨 +9 KB 🚨 |
| Dependency size | 74.92 MB | 77.32 MB | 🚨 +2.41 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 268 | 269 | 🚨 +1 🚨 |
| Self size | 612 KB | 612 KB | 🎉 -1 B 🎉 |
| Dependency size | 64.91 MB | 67.31 MB | 🚨 +2.41 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 105 | 106 | 🚨 +1 🚨 |
| Self size | 1.11 MB | 1.11 MB | 🎉 -25 B 🎉 |
| Dependency size | 42.48 MB | 44.89 MB | 🚨 +2.40 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/test
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 53 | 53 | 0 |
| Self size | 1.52 MB | 1.81 MB | 🚨 +287 KB 🚨 |
| Dependency size | 8.09 MB | 8.09 MB | 🚨 +5 B 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-html-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 93 | 93 | 0 |
| Self size | 4 KB | 4 KB | 0 B |
| Dependency size | 20.21 MB | 20.23 MB | 🚨 +22 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-react-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 182 | 182 | 0 |
| Self size | 24 KB | 24 KB | 0 B |
| Dependency size | 30.97 MB | 30.99 MB | 🚨 +15 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-vue3-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 365 | 366 | 🚨 +1 🚨 |
| Self size | 9 KB | 9 KB | 0 B |
| Dependency size | 45.09 MB | 45.12 MB | 🚨 +29 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.5.0-alpha.19to8.5.0-alpha.20.Once this pull request is merged, it will trigger a new release of version
8.5.0-alpha.20.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:experimental-nextjs-vite#29814@vitest/coverage-v8during postinstall if no coverage reporter is installed #29993If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-alpha.20
@vitest/coverage-v8during postinstall if no coverage reporter is installed - #29993, thanks @ghengeveld!experimental-nextjs-vite- #29814, thanks @ndelangen!