Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Test: Make component tests status row link to the story's tests panel #29992

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Addon Test: Make component tests status row link to the story's tests panel #29992

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7c9f43d
Make component tests status row link to the story's tests panel
ghengeveld Dec 9, 2024
f65dfe1
Merge branch 'next' into link-to-tests-panel
ghengeveld Dec 9, 2024
9c968ff
Cleanup
ghengeveld Dec 9, 2024
8d5fe59
Add missing import
ghengeveld Dec 9, 2024
f124fad
Merge remote-tracking branch 'origin/next' into link-to-tests-panel
valentinpalkovic Dec 10, 2024
fa52f3b
Refactor TestProviderRender to support multiple panels and improve ac…
valentinpalkovic Dec 10, 2024
a1082cd
Improve panel opening logic in TestProviderRender for better handling…
valentinpalkovic Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions code/addons/test/src/components/TestProviderRender.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import type { API } from 'storybook/internal/manager-api';
import { styled, useTheme } from 'storybook/internal/theming';

import {
AccessibilityIcon,
EditIcon,
EyeIcon,
PlayHollowIcon,
Expand All @@ -22,7 +21,7 @@ import {
import { isEqual } from 'es-toolkit';
import { debounce } from 'es-toolkit/compat';

import { type Config, type Details } from '../constants';
import { type Config, type Details, PANEL_ID } from '../constants';
import { type TestStatus } from '../node/reporter';
import { Description } from './Description';
import { TestStatusIcon } from './TestStatusIcon';
Expand Down Expand Up @@ -103,6 +102,12 @@ export const TestProviderRender: FC<

const status = (state.failed ? 'failed' : results[0]?.status) || 'unknown';

const openTestsPanel = (id: string) => {
api.selectStory(id);
api.setSelectedPanel(PANEL_ID);
api.togglePanel(true);
};

return (
<Container {...props}>
<Heading>
Expand Down Expand Up @@ -188,6 +193,11 @@ export const TestProviderRender: FC<
<Extras>
<ListItem
title="Component tests"
onClick={
(status === 'failed' || status === 'warning') && results[0]
? () => openTestsPanel(results[0].storyId)
: null
ghengeveld marked this conversation as resolved.
Show resolved Hide resolved
}
icon={
state.crashed ? (
<TestStatusIcon status="critical" aria-label="status: crashed" />
Expand Down
4 changes: 2 additions & 2 deletions code/addons/test/src/manager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const statusMap: Record<TestStatus, API_StatusValue> = {
addons.register(ADDON_ID, (api) => {
const storybookBuilder = (globalThis as any).STORYBOOK_BUILDER || '';
if (storybookBuilder.includes('vite')) {
const openAddonPanel = () => {
const openTestsPanel = () => {
api.setSelectedPanel(PANEL_ID);
api.togglePanel(true);
};
ghengeveld marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -93,7 +93,7 @@ addons.register(ADDON_ID, (api) => {
? rest.failureMessages.join('\n')
: '',
data: { testRunId },
onClick: openAddonPanel,
onClick: openTestsPanel,
ghengeveld marked this conversation as resolved.
Show resolved Hide resolved
sidebarContextMenu: false,
} as API_StatusObject,
])
Expand Down
4 changes: 2 additions & 2 deletions code/addons/test/src/node/reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export type TestResultResult =
duration: number;
}
| {
status: Extract<TestStatus, 'failed'>;
status: Extract<TestStatus, 'failed' | 'warning'>;
storyId: string;
duration: number;
testRunId: string;
Expand All @@ -41,7 +41,7 @@ export type TestResult = {
results: TestResultResult[];
startTime: number;
endTime: number;
status: Extract<TestStatus, 'passed' | 'failed'>;
status: Extract<TestStatus, 'passed' | 'failed' | 'warning'>;
message?: string;
};

Expand Down
Loading