Revert "Build: Migrate repo to Nx 20" #29820
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
12 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
style: Removing this file will cause vite.config timestamp files to be tracked in git. Consider keeping the ignore rule by moving it to the root .gitignore instead.
| code/.nx/cache | ||
| code/.nx/workspace-data | ||
| code/.vite-inspect | ||
| .nx/cache |
There was a problem hiding this comment.
style: consider keeping .nx/workspace-data ignored to prevent committing temporary Nx workspace data
| @@ -1,9 +1,16 @@ | |||
| { | |||
| "$schema": "./node_modules/nx/schemas/nx-schema.json", | |||
| "extends": "nx/presets/npm.json", | |||
| "cacheDirectory": "../.nx/cache", | |||
There was a problem hiding this comment.
style: cacheDirectory is deprecated in newer Nx versions and should be removed. It defaults to .nx/cache in the workspace root.
| "affected": { | ||
| "defaultBase": "next" | ||
| }, |
There was a problem hiding this comment.
style: affected.defaultBase is redundant with the top-level defaultBase setting on line 6
| @@ -131,7 +138,7 @@ | |||
| "sharedGlobals": ["{workspaceRoot}/tsconfig.json"], | |||
| "production": [ | |||
| "default", | |||
| "!{projectRoot}/src/**/**/*.{test,spec,stories}.?(c|m)[jt]s?(x)?(.snap)", | |||
| "!{projectRoot}/src/**/**/*.{test,spec,stories}.?(c|m)[jt]s?(x)?(.snap),", | |||
There was a problem hiding this comment.
logic: invalid glob pattern - trailing comma inside the pattern will cause file matching issues
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b713e8e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Reverting the PR because CI started to fail.
Reverts #29807
Greptile Summary
This PR reverts the migration to Nx 20 due to CI failures, restoring configurations and dependencies back to Nx 18.0.6 across the codebase.
code/migrations.jsonwith Nx 17.3.0 and 18.0.0 migration configurationscode/package.jsonandscripts/package.json.nx/workspace-dataignore patterns from.gitignoreand.prettierignore