Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Migrate repo to Nx 19 #29801

Closed
wants to merge 7 commits into from
Closed

Conversation

JamesHenry
Copy link
Contributor

@JamesHenry JamesHenry commented Dec 4, 2024

Closes #

What I did

Paired with @kasperpeulen to migrate the code and scripts workspaces to the latest Nx 19 (Nx 20 PR will follow once this is merged).

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.7 MB 77.7 MB 0 B 0.68 0%
initSize 130 MB 130 MB -60 B 0.04 0%
diffSize 52.4 MB 52.4 MB -60 B -0.1 0%
buildSize 6.75 MB 6.75 MB 0 B -1.36 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB 0 B -0.41 0%
buildSbPreviewSize 0 B 0 B 0 B -1.36 -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.56 MB 3.56 MB 0 B -1.36 0%
buildPreviewSize 3.19 MB 3.19 MB 0 B 1.36 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 23.9s 18.5s -5s -427ms 0.37 -29.3%
generateTime 19.2s 20.2s 1s -0.31 5%
initTime 12.8s 12.9s 39ms -0.48 0.3%
buildTime 9.9s 8.7s -1s -265ms -0.58 -14.5%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.7s 4.4s -1s -265ms -1.22 -28.5%
devManagerResponsive 4.2s 3.3s -923ms -1.04 -28%
devManagerHeaderVisible 655ms 539ms -116ms -0.69 -21.5%
devManagerIndexVisible 726ms 612ms -114ms -0.56 -18.6%
devStoryVisibleUncached 2s 1.9s -162ms 0.61 -8.5%
devStoryVisible 727ms 610ms -117ms -0.53 -19.2%
devAutodocsVisible 605ms 521ms -84ms -0.3 -16.1%
devMDXVisible 643ms 494ms -149ms -0.47 -30.2%
buildManagerHeaderVisible 674ms 524ms -150ms -0.67 -28.6%
buildManagerIndexVisible 792ms 603ms -189ms -0.37 -31.3%
buildStoryVisible 617ms 488ms -129ms -0.86 -26.4%
buildAutodocsVisible 566ms 398ms -168ms -0.92 -42.2%
buildMDXVisible 520ms 434ms -86ms -0.55 -19.8%

@kasperpeulen kasperpeulen added build Internal-facing build tooling & test updates ci:normal labels Dec 4, 2024
@kasperpeulen kasperpeulen changed the title chore: migrate repo to nx 19 Build: migrate repo to nx 19 Dec 4, 2024
Copy link

nx-cloud bot commented Dec 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ff25dfc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf changed the title Build: migrate repo to nx 19 Build: Migrate repo to Nx 19 Dec 4, 2024
@JamesHenry JamesHenry mentioned this pull request Dec 4, 2024
8 tasks
@JamesHenry
Copy link
Contributor Author

Closing in favour of #29807

@JamesHenry JamesHenry closed this Dec 4, 2024
@JamesHenry JamesHenry deleted the nx-19 branch December 4, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants