Core: Emit deprecated `TESTING_MODULE_RUN_ALL_REQUEST` for backward compatibility #29711

ghengeveld · 2024-11-26T10:38:14Z

What I did

Restored the TESTING_MODULE_RUN_ALL_REQUEST and marked it deprecated. This event is relied upon by the Visual Tests addon so we cannot remove it (yet).

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

stories
unit tests
integration tests
end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Add or update documentation reflecting your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Checklist for Maintainers

When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
- bug: Internal changes that fixes incorrect behavior.
- maintenance: User-facing maintenance tasks.
- dependencies: Upgrading (sometimes downgrading) dependencies.
- build: Internal-facing build tooling & test updates. Will not show up in release changelog.
- cleanup: Minor cleanup style change. Will not show up in release changelog.
- documentation: Documentation only changes. Will not show up in release changelog.
- feature request: Introducing a new feature.
- BREAKING CHANGE: Changes that break compatibility in some way with current major version.
- other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name	before	after	diff	z	%
createSize	0 B	0 B	0 B	-	-
generateSize	78.5 MB	77.7 MB	-799 kB	-52.38	-1%
initSize	144 MB	143 MB	-789 kB	-15.25	-0.6%
diffSize	65.2 MB	65.2 MB	10.5 kB	0.8	0%
buildSize	6.83 MB	6.83 MB	689 B	-0.34	0%
buildSbAddonsSize	1.51 MB	1.51 MB	211 B	0.33	0%
buildSbCommonSize	195 kB	195 kB	0 B	-	0%
buildSbManagerSize	1.86 MB	1.86 MB	331 B	-0.35	0%
buildSbPreviewSize	271 kB	271 kB	147 B	0.33	0.1%
buildStaticSize	0 B	0 B	0 B	-	-
buildPrebuildSize	3.83 MB	3.83 MB	689 B	-0.34	0%
buildPreviewSize	3 MB	3 MB	0 B	0.51	0%
testBuildSize	0 B	0 B	0 B	-	-
testBuildSbAddonsSize	0 B	0 B	0 B	-	-
testBuildSbCommonSize	0 B	0 B	0 B	-	-
testBuildSbManagerSize	0 B	0 B	0 B	-	-
testBuildSbPreviewSize	0 B	0 B	0 B	-	-
testBuildStaticSize	0 B	0 B	0 B	-	-
testBuildPrebuildSize	0 B	0 B	0 B	-	-
testBuildPreviewSize	0 B	0 B	0 B	-	-

name	before	after	diff	z	%
createTime	6.4s	14.1s	7.7s	-0.5	54.5%
generateTime	18.6s	20.9s	2.3s	0.37	11%
initTime	13.5s	15.2s	1.7s	0.56	11.2%
buildTime	8.7s	7.9s	-786ms	-0.68	-9.9%
testBuildTime	0ms	0ms	0ms	-	-
devPreviewResponsive	5.5s	5.4s	-109ms	-0.65	-2%
devManagerResponsive	3.5s	3.3s	-192ms	-0.84	-5.8%
devManagerHeaderVisible	677ms	532ms	-145ms	-0.71	-27.3%
devManagerIndexVisible	744ms	568ms	-176ms	-1.14	-31%
devStoryVisibleUncached	929ms	951ms	22ms	-0.34	2.3%
devStoryVisible	701ms	568ms	-133ms	-0.96	-23.4%
devAutodocsVisible	376ms	458ms	82ms	-0.56	17.9%
devMDXVisible	577ms	540ms	-37ms	-0.07	-6.9%
buildManagerHeaderVisible	717ms	570ms	-147ms	-0.08	-25.8%
buildManagerIndexVisible	753ms	587ms	-166ms	-0.1	-28.3%
buildStoryVisible	716ms	562ms	-154ms	-0.17	-27.4%
buildAutodocsVisible	549ms	471ms	-78ms	-0.24	-16.6%
buildMDXVisible	503ms	427ms	-76ms	-0.64	-17.8%

Greptile Summary

Added back the deprecated TESTING_MODULE_RUN_ALL_REQUEST event for backward compatibility with the Visual Tests addon, ensuring both new and old event names are emitted when running tests.

Added deprecated TESTING_MODULE_RUN_ALL_REQUEST event in code/core/src/core-events/index.ts
Modified code/core/src/manager-api/modules/experimental_testmodule.ts to emit both new and deprecated events
Maintained backward compatibility while encouraging migration to TESTING_MODULE_RUN_REQUEST

_{💡 (4/5) You can add custom instructions or style guidelines for the bot here!}

…ds compatibility

greptile-apps

_{2 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

code/core/src/manager-api/modules/experimental_testmodule.ts

nx-cloud · 2024-11-26T10:42:30Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2161c5a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx run-many -t build --parallel=3

Sent with 💌 from NxCloud.

storybook-pr-benchmarking · 2024-11-26T12:16:43Z

Package Benchmarks

^{Commit: 2161c5a, ran on 26 November 2024 at 12:16:40 UTC}

The following packages have significant changes to their size or dependencies:

`@storybook/addon-storysource`

	Before	After	Difference
Dependency count	7	7	0
Self size	1.89 MB	1.89 MB	0 B
Dependency size	10.12 MB	10.27 MB	🚨 +142 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/builder-webpack5`

	Before	After	Difference
Dependency count	223	223	0
Self size	79 KB	79 KB	0 B
Dependency size	29.56 MB	29.60 MB	🚨 +42 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/angular`

	Before	After	Difference
Dependency count	258	258	0
Self size	362 KB	362 KB	0 B
Dependency size	34.49 MB	34.54 MB	🚨 +42 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/ember`

	Before	After	Difference
Dependency count	250	250	0
Self size	22 KB	22 KB	0 B
Dependency size	31.96 MB	32.00 MB	🚨 +42 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/html-webpack5`

	Before	After	Difference
Dependency count	233	233	0
Self size	6 KB	6 KB	0 B
Dependency size	30.10 MB	30.15 MB	🚨 +42 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/nextjs`

	Before	After	Difference
Dependency count	587	587	0
Self size	464 KB	464 KB	0 B
Dependency size	83.77 MB	83.81 MB	🚨 +42 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preact-webpack5`

	Before	After	Difference
Dependency count	231	231	0
Self size	6 KB	6 KB	0 B
Dependency size	29.68 MB	29.72 MB	🚨 +42 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-webpack5`

	Before	After	Difference
Dependency count	309	309	0
Self size	6 KB	6 KB	0 B
Dependency size	40.84 MB	40.88 MB	🚨 +42 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/server-webpack5`

	Before	After	Difference
Dependency count	241	241	0
Self size	14 KB	14 KB	0 B
Dependency size	31.08 MB	31.12 MB	🚨 +42 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/svelte-webpack5`

	Before	After	Difference
Dependency count	296	296	0
Self size	6 KB	6 KB	0 B
Dependency size	37.67 MB	37.71 MB	🚨 +42 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/vue3-vite`

	Before	After	Difference
Dependency count	107	107	0
Self size	15 KB	15 KB	0 B
Dependency size	42.52 MB	42.55 MB	🚨 +33 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/vue3-webpack5`

	Before	After	Difference
Dependency count	483	483	0
Self size	6 KB	6 KB	0 B
Dependency size	54.08 MB	54.12 MB	🚨 +42 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/web-components-webpack5`

	Before	After	Difference
Dependency count	231	231	0
Self size	5 KB	5 KB	0 B
Dependency size	29.73 MB	29.77 MB	🚨 +42 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/cli`

	Before	After	Difference
Dependency count	390	390	0
Self size	484 KB	484 KB	0 B
Dependency size	74.48 MB	74.64 MB	🚨 +153 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/codemod`

	Before	After	Difference
Dependency count	270	270	0
Self size	612 KB	612 KB	0 B
Dependency size	64.48 MB	64.63 MB	🚨 +153 KB 🚨
Bundle Size Analyzer	Link	Link

`create-storybook`

	Before	After	Difference
Dependency count	105	105	0
Self size	1.11 MB	1.11 MB	0 B
Dependency size	42.34 MB	42.48 MB	🚨 +144 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/source-loader`

	Before	After	Difference
Dependency count	5	5	0
Self size	41 KB	41 KB	0 B
Dependency size	10.07 MB	10.21 MB	🚨 +142 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-vue3-webpack`

	Before	After	Difference
Dependency count	366	366	0
Self size	9 KB	9 KB	0 B
Dependency size	45.00 MB	45.04 MB	🚨 +42 KB 🚨
Bundle Size Analyzer	Link	Link

Also emit deprecated TESTING_MODULE_RUN_ALL_REQUEST event for backwar…

f0ebdc1

…ds compatibility

ghengeveld added bug ci:normal labels Nov 26, 2024

ghengeveld requested review from ndelangen and JReinhold November 26, 2024 10:38

greptile-apps bot reviewed Nov 26, 2024

View reviewed changes

code/core/src/manager-api/modules/experimental_testmodule.ts Show resolved Hide resolved

JReinhold approved these changes Nov 26, 2024

View reviewed changes

Add missing exports

2161c5a

ghengeveld merged commit ac03998 into next Nov 26, 2024
60 checks passed

ghengeveld deleted the backwards-compat-run-all branch November 26, 2024 13:56

github-actions bot mentioned this pull request Nov 27, 2024

Release: Prerelease 8.5.0-alpha.11 #29700

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core: Emit deprecated `TESTING_MODULE_RUN_ALL_REQUEST` for backward compatibility #29711

Core: Emit deprecated `TESTING_MODULE_RUN_ALL_REQUEST` for backward compatibility #29711

ghengeveld commented Nov 26, 2024 •

edited by storybook-pr-benchmarking bot

Loading

greptile-apps bot left a comment

nx-cloud bot commented Nov 26, 2024 •

edited

Loading

storybook-pr-benchmarking bot commented Nov 26, 2024

Core: Emit deprecated TESTING_MODULE_RUN_ALL_REQUEST for backward compatibility #29711

Core: Emit deprecated TESTING_MODULE_RUN_ALL_REQUEST for backward compatibility #29711

Conversation

ghengeveld commented Nov 26, 2024 • edited by storybook-pr-benchmarking bot Loading

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

Documentation

Checklist for Maintainers

🦋 Canary release

Greptile Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

nx-cloud bot commented Nov 26, 2024 • edited Loading

☁️ Nx Cloud Report

storybook-pr-benchmarking bot commented Nov 26, 2024

Package Benchmarks

@storybook/addon-storysource

@storybook/builder-webpack5

@storybook/angular

@storybook/ember

@storybook/html-webpack5

@storybook/nextjs

@storybook/preact-webpack5

@storybook/react-webpack5

@storybook/server-webpack5

@storybook/svelte-webpack5

@storybook/vue3-vite

@storybook/vue3-webpack5

@storybook/web-components-webpack5

@storybook/cli

@storybook/codemod

create-storybook

@storybook/source-loader

@storybook/preset-vue3-webpack

Core: Emit deprecated `TESTING_MODULE_RUN_ALL_REQUEST` for backward compatibility #29711

Core: Emit deprecated `TESTING_MODULE_RUN_ALL_REQUEST` for backward compatibility #29711

ghengeveld commented Nov 26, 2024 •

edited by storybook-pr-benchmarking bot

Loading

nx-cloud bot commented Nov 26, 2024 •

edited

Loading

`@storybook/addon-storysource`

`@storybook/builder-webpack5`

`@storybook/angular`

`@storybook/ember`

`@storybook/html-webpack5`

`@storybook/nextjs`

`@storybook/preact-webpack5`

`@storybook/react-webpack5`

`@storybook/server-webpack5`

`@storybook/svelte-webpack5`

`@storybook/vue3-vite`

`@storybook/vue3-webpack5`

`@storybook/web-components-webpack5`

`@storybook/cli`

`@storybook/codemod`

`create-storybook`

`@storybook/source-loader`

`@storybook/preset-vue3-webpack`