Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add workaround resolution for Angular sandboxes #29690

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 22, 2024

Relates to #29689

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Here's my concise summary of the pull request:

Adds workaround resolutions for Angular sandboxes in Yarn projects to fix dependency issues with Vite 5 and @thednp/shorty package.

  • Added Angular CLI templates (15-ts, default-ts, prerelease) to sandboxesNeedingWorkarounds array in scripts/tasks/sandbox-parts.ts
  • Added @thednp/shorty version 2.0.7 resolution in scripts/utils/yarn.ts to fix Yarn workflow error from @compodoc dependency chain
  • Removed outdated workaround resolutions for 'enhanced-resolve' and '@storybook/csf'
  • Addresses issue Angular - Assertion failed: Unsupported workflow in Yarn projects #29689 where Angular projects fail with "Unsupported workflow" error in Yarn

@yannbf yannbf added build Internal-facing build tooling & test updates ci:normal labels Nov 22, 2024
@yannbf yannbf merged commit fa32c7b into next Nov 22, 2024
3 of 6 checks passed
@yannbf yannbf deleted the yann/fix-angular-sandboxes-ci branch November 22, 2024 17:07
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Nov 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8c28786. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant