Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Patch 8.4.6 #29679

Open
wants to merge 6 commits into
base: latest-release
Choose a base branch
from
Open

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 21, 2024

This is an automated pull request that bumps the version from 8.4.5 to 8.4.6.
Once this pull request is merged, it will trigger a new release of version 8.4.6.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🐛 Bug: Angular: Default to standalone components in Angular v19 #29677
  • 🐛 Bug: Addon Test: Use pathe for better windows support #29676
  • ✨ Feature Request: Frameworks: Add Vite 6 support #29710
  • 📝 Documentation: Docs: Maintenance - Fix snippets and documentation #29683

🍒 Manual cherry picking needed!

The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.

  • #29676: git cherry-pick -m1 -x 1bb5920115f5a4978bbe58bd51a10e1591cf5c06
  • #29710: git cherry-pick -m1 -x 8e5be14c49a2b42ee473b79cfd6b78858ca2e172

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.4.6

  • Addon Test: Use pathe for better windows support - #29676, thanks @yannbf!
  • Angular: Default to standalone components in Angular v19 - #29677, thanks @ingowagner!
  • Frameworks: Add Vite 6 support - #29710, thanks @yannbf!

@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Nov 21, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@storybook-bot storybook-bot force-pushed the version-patch-from-8.4.5 branch 5 times, most recently from 773f9b8 to 151e413 Compare November 23, 2024 05:02
@storybook-bot storybook-bot force-pushed the version-patch-from-8.4.5 branch 6 times, most recently from efb7704 to 74c24bd Compare November 26, 2024 14:58
yannbf and others added 3 commits November 26, 2024 16:08
Angular: Default to standalone components in Angular v19
(cherry picked from commit 8ba4fb5)
Docs: Maintenance - Fix snippets and documentation
(cherry picked from commit 896be2b)
@yannbf yannbf added freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. labels Nov 26, 2024
Copy link

nx-cloud bot commented Nov 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4a81359. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants