-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Patch 8.4.3 #29590
Release: Patch 8.4.3 #29590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
#29587 contains a bug for Next.js 13 projects |
967bea7
to
3b3f670
Compare
Looks like next15 support is coming out with this release: this is amazing news! Thanks for looking into this @yannbf ❤️ |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c946bc1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
3f8947a
to
6880ae1
Compare
c9487ee
to
3edae5c
Compare
This is an automated pull request that bumps the version from
8.4.2
to8.4.3
.Once this pull request is merged, it will trigger a new release of version
8.4.3
.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next
, that will be part of this release:🍒 Manual cherry picking needed!
The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.
git cherry-pick -m1 -x fa138f65563e2a277b311b52686662fcd339d787
git cherry-pick -m1 -x 22df58c55fbedb1b7ad818ca856700086f34649a
If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.4.3