Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Patch 8.4.3 #29590

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Release: Patch 8.4.3 #29590

merged 7 commits into from
Nov 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 12, 2024

This is an automated pull request that bumps the version from 8.4.2 to 8.4.3.
Once this pull request is merged, it will trigger a new release of version 8.4.3.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 🔧 Maintenance: Next.js: Add support for Next 15 #29587
  • 🐛 Bug: Addon Test: Optimize internal dependencies #29595
  • 🏗️ Build: Build: Exclude server action stories to run in next 13 #29592
  • 🏗️ Build: Build: Move more stories out of next 13 sandbox #29593
  • 📝 Documentation: Docs: Fix global viewports options example #29589

🍒 Manual cherry picking needed!

The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.

  • #29587: git cherry-pick -m1 -x fa138f65563e2a277b311b52686662fcd339d787
  • #29593: git cherry-pick -m1 -x 22df58c55fbedb1b7ad818ca856700086f34649a

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

8.4.3

@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Nov 12, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@valentinpalkovic
Copy link
Contributor

#29587 contains a bug for Next.js 13 projects

@storybook-bot storybook-bot force-pushed the version-patch-from-8.4.2 branch from 967bea7 to 3b3f670 Compare November 12, 2024 10:33
@valentinpalkovic valentinpalkovic added freeze Freeze the Release PR with this label ci:daily Run the CI jobs that normally run in the daily job. and removed ci: do not merge labels Nov 12, 2024
@terrymun
Copy link

Looks like next15 support is coming out with this release: this is amazing news! Thanks for looking into this @yannbf ❤️

Copy link

nx-cloud bot commented Nov 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c946bc1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@yannbf yannbf removed the freeze Freeze the Release PR with this label label Nov 12, 2024
@storybook-bot storybook-bot force-pushed the version-patch-from-8.4.2 branch from 3f8947a to 6880ae1 Compare November 12, 2024 15:00
@yannbf yannbf added the freeze Freeze the Release PR with this label label Nov 12, 2024
@yannbf yannbf removed the freeze Freeze the Release PR with this label label Nov 13, 2024
yannbf and others added 4 commits November 13, 2024 12:52
Build: Exclude server action stories to run in next 13
(cherry picked from commit 0676c9c)
…xample

Docs: Fix global viewports options example
(cherry picked from commit 53ffd11)
…ancy-test

Addon Test: Optimize internal dependencies

(cherry picked from commit cb66c33)
@storybook-bot storybook-bot force-pushed the version-patch-from-8.4.2 branch from c9487ee to 3edae5c Compare November 13, 2024 12:52
@yannbf yannbf added the freeze Freeze the Release PR with this label label Nov 13, 2024
shilman and others added 2 commits November 13, 2024 15:23
Next.js: Add support for Next 15

(cherry picked from commit fa138f6)
…-again

Build: Move more stories out of next 13 sandbox
(cherry picked from commit 22df58c)
@yannbf yannbf merged commit e266b17 into latest-release Nov 13, 2024
104 of 105 checks passed
@yannbf yannbf deleted the version-patch-from-8.4.2 branch November 13, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants