Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Sidebar context menu addon API #29557
UI: Sidebar context menu addon API #29557
Changes from 10 commits
1abc353
c69c1f3
716917d
a2d07fb
82c5cde
7bfc2ad
15e0f2c
9faaa59
653ff53
b833d03
d5995fd
9d4eae2
b20b07c
7ad41a7
4ea557e
74972a7
cab4b71
17b2890
76687a7
0a0c36b
39be69f
4d8c845
4d4bc94
800de95
d99f0e6
350cee7
d23899e
4582440
6c411d4
011b854
ad55d61
1c85387
f8cbd83
a35701d
166aeb6
8b63bcb
dfc147a
a9e7905
e5e4499
8147355
7e43ecd
c912e0e
9e841f8
3a2415b
5811cdb
7454f3c
2b254b7
ec28fa2
d2b09b1
dbdd73a
2873064
5101314
3d70d51
14f3ab4
adf6180
ac49cf1
fe2cec7
b6aa053
f771bdf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an optimization that makes a lot of sense to me...
Why call a function which we will not use the returned JSX of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Potential runtime error if testProviders[id] is undefined when spreading